From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966224AbcAZOdD (ORCPT ); Tue, 26 Jan 2016 09:33:03 -0500 Received: from vms173021pub.verizon.net ([206.46.173.21]:60155 "EHLO vms173021pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966209AbcAZOc4 (ORCPT ); Tue, 26 Jan 2016 09:32:56 -0500 X-Greylist: delayed 3604 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 Jan 2016 09:32:56 EST X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=btqxfxui c=1 sm=1 tr=0 a=bXmWQgKa9n63w7XTPFb8JQ==:117 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=7aQ_Q-yQQ-AA:10 a=MMo5lIt-nALHeHcj85MA:9 a=QEXdDO2ut3YA:10 Reply-to: minyard@acm.org Subject: Re: ipmi_si feature request: SMBIOS-based autoloading References: To: Andy Lutomirski , OpenIPMI Developers , "linux-kernel@vger.kernel.org" , brijeshkumar.singh@amd.com, Jean Delvare From: Corey Minyard Message-id: <56A7757A.6040704@acm.org> Date: Tue, 26 Jan 2016 07:32:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/24/2016 07:45 PM, Andy Lutomirski wrote: > ipmi_si doesn't autoload on systems where it's found via SMBIOS. > Could that be fixed? I'm not really sure. I kind of assumed this was handled in userland like the ACPI tables. I don't think there are many systems that have SMBIOS and not ACPI, so I'm not sure of the impact here or what to do. > If I were doing it, I'd suggest rigging up some code that's compiled > in to the main kernel even if ipmi_si is a module that creates the > platform device if the dmi device is there and then set up a modalias > so that the platofrm device causes ipmi_si to load. > > (In general, having the same driver create the platform device and > register the platform driver means that autoloading is unlikely to > work right. See arch/x86/kernel/pmem.c for an example of a weird > legacy device that gets this right.) This sounds like kind of a hack. > Alternatively, maybe /sys/firmware/dmi could learn how to advertise > modaliases. But that might be a giant mess to solve a tiny problem. This sounds like the right way, but you are probably right. Are there any other resources that could benefit from this? I"m guessing not. There is already a "dmi_save_ipmi_device" function that gets called when scanning the SMBIOS table (see drivers/firmware/dmi_scan.c). Maybe a tie-in there? That happens pretty early, though, I'm not sure if it's too early. Of course it would be easy to have a file like pmem.c that detects if an IPMI device is in the SMBIOS table and create a platform device for it. Are you willing to do this work? -corey