From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966456AbcAZPaa (ORCPT ); Tue, 26 Jan 2016 10:30:30 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:38901 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965983AbcAZPaZ (ORCPT ); Tue, 26 Jan 2016 10:30:25 -0500 Subject: Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384 To: William Breathitt Gray , wim@iguana.be References: <20160126143106.GA5539@sophia> Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <56A7910E.2040808@roeck-us.net> Date: Tue, 26 Jan 2016 07:30:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160126143106.GA5539@sophia> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2016 06:31 AM, William Breathitt Gray wrote: > On 01/25/2016 5:11 PM, Guenter Roeck wrote: >>> + dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n", >>> + timeout, WATCHDOG_TIMEOUT); >> >> Multi-line alignment is off by one character. > > I used tabs to align the lines to 8-character boundaries. Should I add > an additional space to align the "timeout" argument with the "dev" > argument? > Continuation line alignment should be with "(", so, yes, on the same column as "dev". Thanks, Guenter