'select' on deleted KEYS_DEBUG_PROC_KEYS option

'select' on deleted KEYS_DEBUG_PROC_KEYS option

[Andreas Ziegler]

Hi Dmitry,

your commit f4dc37785e9b ("integrity: define '.evm' as a builtin
'trusted' keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig
option, which has a 'select' to KEYS_DEBUG_PROC_KEYS.

This option, however, has been removed over a year ago by commit
dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y")
and -- besides the 'select' mentioned above -- only occurs inside
(outdated) defconfigs.

Should I prepare a simple patch removing the select?

Best regards,

Andreas

RE: 'select' on deleted KEYS_DEBUG_PROC_KEYS option

[Dmitry Kasatkin]

Hi,

Yes, please make a patch.

Thanks for noticing,

Dmitry
________________________________________
From: Andreas Ziegler [andreas.ziegler@fau.de]
Sent: Tuesday, January 26, 2016 5:39 PM
To: Dmitry Kasatkin
Cc: David Howells; James Morris; Serge E. Hallyn; linux-kernel@vger.kernel.org
Subject: 'select' on deleted KEYS_DEBUG_PROC_KEYS option

Hi Dmitry,

your commit f4dc37785e9b ("integrity: define '.evm' as a builtin
'trusted' keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig
option, which has a 'select' to KEYS_DEBUG_PROC_KEYS.

This option, however, has been removed over a year ago by commit
dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y")
and -- besides the 'select' mentioned above -- only occurs inside
(outdated) defconfigs.

Should I prepare a simple patch removing the select?

Best regards,

Andreas

[PATCH] security: Remove select to deleted KEYS_DEBUG_PROC_KEYS option

[Andreas Ziegler]

Commit f4dc37785e9b ("integrity: define '.evm' as a builtin 'trusted'
keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig option.

This option 'select's KEYS_DEBUG_PROC_KEYS which has been removed
earlier by commit dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional
if CONFIG_KEYS=y"). This patch removes the inoperative select.

Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
 security/integrity/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 21d7568..7543398 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -45,7 +45,6 @@ config INTEGRITY_TRUSTED_KEYRING
 	bool "Require all keys on the integrity keyrings be signed"
 	depends on SYSTEM_TRUSTED_KEYRING
 	depends on INTEGRITY_ASYMMETRIC_KEYS
-	select KEYS_DEBUG_PROC_KEYS
 	default y
 	help
 	   This option requires that all keys added to the .ima and
-- 
1.9.1

Re: 'select' on deleted KEYS_DEBUG_PROC_KEYS option

[David Howells]

I've posted a patch to fix this and a bunch of other refs.

David