* 'select' on deleted KEYS_DEBUG_PROC_KEYS option
@ 2016-01-26 15:39 Andreas Ziegler
2016-01-26 15:47 ` Dmitry Kasatkin
2016-02-03 15:17 ` 'select' on " David Howells
0 siblings, 2 replies; 4+ messages in thread
From: Andreas Ziegler @ 2016-01-26 15:39 UTC (permalink / raw)
To: Dmitry Kasatkin
Cc: David Howells, James Morris, Serge E. Hallyn, linux-kernel
Hi Dmitry,
your commit f4dc37785e9b ("integrity: define '.evm' as a builtin
'trusted' keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig
option, which has a 'select' to KEYS_DEBUG_PROC_KEYS.
This option, however, has been removed over a year ago by commit
dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y")
and -- besides the 'select' mentioned above -- only occurs inside
(outdated) defconfigs.
Should I prepare a simple patch removing the select?
Best regards,
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: 'select' on deleted KEYS_DEBUG_PROC_KEYS option
2016-01-26 15:39 'select' on deleted KEYS_DEBUG_PROC_KEYS option Andreas Ziegler
@ 2016-01-26 15:47 ` Dmitry Kasatkin
2016-01-26 15:56 ` [PATCH] security: Remove select to " Andreas Ziegler
2016-02-03 15:17 ` 'select' on " David Howells
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Kasatkin @ 2016-01-26 15:47 UTC (permalink / raw)
To: Andreas Ziegler
Cc: David Howells, James Morris, Serge E. Hallyn,
linux-kernel@vger.kernel.org
Hi,
Yes, please make a patch.
Thanks for noticing,
Dmitry
________________________________________
From: Andreas Ziegler [andreas.ziegler@fau.de]
Sent: Tuesday, January 26, 2016 5:39 PM
To: Dmitry Kasatkin
Cc: David Howells; James Morris; Serge E. Hallyn; linux-kernel@vger.kernel.org
Subject: 'select' on deleted KEYS_DEBUG_PROC_KEYS option
Hi Dmitry,
your commit f4dc37785e9b ("integrity: define '.evm' as a builtin
'trusted' keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig
option, which has a 'select' to KEYS_DEBUG_PROC_KEYS.
This option, however, has been removed over a year ago by commit
dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional if CONFIG_KEYS=y")
and -- besides the 'select' mentioned above -- only occurs inside
(outdated) defconfigs.
Should I prepare a simple patch removing the select?
Best regards,
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] security: Remove select to deleted KEYS_DEBUG_PROC_KEYS option
2016-01-26 15:47 ` Dmitry Kasatkin
@ 2016-01-26 15:56 ` Andreas Ziegler
0 siblings, 0 replies; 4+ messages in thread
From: Andreas Ziegler @ 2016-01-26 15:56 UTC (permalink / raw)
To: Dmitry Kasatkin
Cc: James Morris, Serge E. Hallyn, linux-kernel,
linux-security-module, Andreas Ziegler
Commit f4dc37785e9b ("integrity: define '.evm' as a builtin 'trusted'
keyring") introduces the INTEGRITY_TRUSTED_KEYRING Kconfig option.
This option 'select's KEYS_DEBUG_PROC_KEYS which has been removed
earlier by commit dabd39cc2fb1 ("KEYS: Make /proc/keys unconditional
if CONFIG_KEYS=y"). This patch removes the inoperative select.
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
security/integrity/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 21d7568..7543398 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -45,7 +45,6 @@ config INTEGRITY_TRUSTED_KEYRING
bool "Require all keys on the integrity keyrings be signed"
depends on SYSTEM_TRUSTED_KEYRING
depends on INTEGRITY_ASYMMETRIC_KEYS
- select KEYS_DEBUG_PROC_KEYS
default y
help
This option requires that all keys added to the .ima and
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: 'select' on deleted KEYS_DEBUG_PROC_KEYS option
2016-01-26 15:39 'select' on deleted KEYS_DEBUG_PROC_KEYS option Andreas Ziegler
2016-01-26 15:47 ` Dmitry Kasatkin
@ 2016-02-03 15:17 ` David Howells
1 sibling, 0 replies; 4+ messages in thread
From: David Howells @ 2016-02-03 15:17 UTC (permalink / raw)
To: Andreas Ziegler
Cc: dhowells, Dmitry Kasatkin, James Morris, Serge E. Hallyn,
linux-kernel
I've posted a patch to fix this and a bunch of other refs.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-03 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-26 15:39 'select' on deleted KEYS_DEBUG_PROC_KEYS option Andreas Ziegler
2016-01-26 15:47 ` Dmitry Kasatkin
2016-01-26 15:56 ` [PATCH] security: Remove select to " Andreas Ziegler
2016-02-03 15:17 ` 'select' on " David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox