From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752584AbcA0Br6 (ORCPT ); Tue, 26 Jan 2016 20:47:58 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:26450 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287AbcA0Brz (ORCPT ); Tue, 26 Jan 2016 20:47:55 -0500 X-AuditID: cbfec7f5-f79b16d000005389-3d-56a821c81d10 Subject: Re: [PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-5-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56A821C1.6090402@samsung.com> Date: Wed, 27 Jan 2016 10:47:45 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453836020-29579-5-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t/xy7onFFeEGTzvU7TouLaYyeL6l+es Fm/ermGyeP3C0KL/8Wtmi6X7VrNYXN41h81ixvl9TBb7OzsYHTg9nmy6yOixZ+JJNo9NqzrZ PHqb37F5bOm/y+7Rt2UVo8fnTXIB7FFcNimpOZllqUX6dglcGf/+/mEqeMJTcfrnQbYGxt1c XYycHBICJhJbv05jh7DFJC7cW8/WxcjFISSwlFHiZNtORgjnKaPE5DUdTCBVwgKJEtOauphB bBGBUIl/F29DFTUzSqz8sJYNJMEs8I5RYsIeWxCbTcBYYvPyJWBxXgEtiY2NW8BsFgFVie8v +xhBbFGBCInDnV3sEDWCEj8m32MBsTkF3CU2t24AWswBNFNP4v5FLYjx8hKb17xlnsAoMAtJ xyyEqllIqhYwMq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECImFrzsYlx6zOsQowMGoxMN7 Y//yMCHWxLLiytxDjBIczEoivMkMK8KEeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9 sSQ1OzW1ILUIJsvEwSnVwOjy6/ckRrtd33d++lETtsaAP2u/zcGX8Q5rufdw3DJas6dfrHde jUJkhLbyNU6Ps/P7CquqREJOLv/BwSh67EDyOm+3mQrJHfbTqm4lcIhvOCK+9t4nXgM9j9Nr f/Ik+Z3Qv8R7r6d0wnyepekiZ9KNE9gT1BdxZKmunqFe7/2Td/qD3pPC85VYijMSDbWYi4oT ATfTFLOBAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.01.2016 04:20, Javier Martinez Canillas wrote: > The driver has some hard-coded values such as the minimum delay needed > before a RTC update or the mask used for the sec/min/hour/etc registers. > > Use a data structure that contains these values and pass as driver data > using the platform device ID table for each device. > > This allows to make the driver's ops callbacks more generic so other RTC > that are similar but don't have the same values can also be supported. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > > --- > > Changes in v3: > - Fix max77686 delay. Suggested by Krzysztof Kozlowski. > - Assign mask to u8 instead of int. Suggested by Krzysztof Kozlowski. > - Add Laxman Dewangan's Acked-by tag to patch #4. > > Changes in v2: > - Add a max77686 prefix to rtc_driver_data. Suggested by Krzysztof Kozlowski. > - Comment about the .delay and .mask fields. Suggested by Krzysztof Kozlowski. > - Change .mask type to u8. Suggested by Krzysztof Kozlowski. > - Make .drv_data field const. Suggested by Krzysztof Kozlowski. > - Don't cast to drop const on .drv_data asign. Suggested by Krzysztof Kozlowski. > - Use platform_get_device_id() macro. Suggested by Krzysztof Kozlowski. > > drivers/rtc/rtc-max77686.c | 51 ++++++++++++++++++++++++++++++---------------- > 1 file changed, 34 insertions(+), 17 deletions(-) > Tested on Trats2 (max77686): Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof