From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbcA0BxQ (ORCPT ); Tue, 26 Jan 2016 20:53:16 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:18837 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800AbcA0BxM (ORCPT ); Tue, 26 Jan 2016 20:53:12 -0500 X-AuditID: cbfec7f5-f79b16d000005389-8c-56a82305d797 Subject: Re: [PATCH v3 05/10] rtc: max77686: Add an indirection level to access RTC registers To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-6-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56A82301.1000301@samsung.com> Date: Wed, 27 Jan 2016 10:53:05 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453836020-29579-6-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t/xK7qsyivCDP6eV7HouLaYyeL6l+es Fm/ermGyeP3C0KL/8Wtmi6X7VrNYXN41h81ixvl9TBb7OzsYHTg9nmy6yOixZ+JJNo9NqzrZ PHqb37F5bOm/y+7Rt2UVo8fnTXIB7FFcNimpOZllqUX6dglcGfc7m9kKbnNW7Ju3mKWB8R97 FyMnh4SAicTP+zfYIGwxiQv31gPZXBxCAksZJWZum8MK4TxllDi1dDkLSJWwQLzEvC8NzCC2 iECoxL+LtxkhipoZJdpO/AcrYhZ4xygxYY8tiM0mYCyxefkSsBW8AloS+1YuBrNZBFQlPuy6 wgpiiwpESBzu7GKHqBGU+DH5HtgcTgF3iYMvzzB1MXIAzdSTuH9RC2K8vMTmNW+ZJzAKzELS MQuhahaSqgWMzKsYRVNLkwuKk9JzjfSKE3OLS/PS9ZLzczcxQmLh6w7GpcesDjEKcDAq8fDe 2L88TIg1say4MvcQowQHs5IIbzLDijAh3pTEyqrUovz4otKc1OJDjNIcLErivDN3vQ8REkhP LEnNTk0tSC2CyTJxcEo1MF5iF5hQeu5oxcGdkzaHfstxe1mxjdOvX4DBMvnHRftbPI+X7F08 z/W5zrPocAZZJo0FAhv5fv9ukH7/PHz6rDWMwYFxCgs2v9+nezXh2bXjbfWFt003KzQvy8o9 cTK1P3t/ksfULbvlb2tLzNI48OlUz7ulobeDqxlyQjaUTV/tVpJRdWWx8TYlluKMREMt5qLi RAC2qtAUgQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.01.2016 04:20, Javier Martinez Canillas wrote: > The max77686 driver is generic enough that can be used for other > Maxim RTC IP blocks but these might not have the same registers > layout so instead of accessing the registers directly, add a map > to translate offsets to the real registers addresses for each IP. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > > --- > > Changes in v3: > - Add Laxman Dewangan's Acked-by tag to patch #5. > > Changes in v2: > - Rename rtc_reg to max77686_rtc_reg_offset. Suggested by Krzysztof Kozlowski. > - Comment what's mapped by max77686_map. Suggested by Krzysztof Kozlowski. > - Use max77686_map array indexes in init. Suggested by Krzysztof Kozlowski. > - Remove REG_RTC_UPDATE1 since is not used by neither max77686 nor max77802. > > drivers/rtc/rtc-max77686.c | 90 ++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 80 insertions(+), 10 deletions(-) > Thanks for changes, looks good now. Tested on Trats2 (max77686): Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof