From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753246AbcA0CAt (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jan 2016 21:00:49 -0500
Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:34455 "EHLO
	mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753062AbcA0CAq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jan 2016 21:00:46 -0500
X-IronPort-AV: E=Sophos;i="5.22,352,1449561600"; 
   d="scan'208";a="86259595"
Subject: Re: [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly
To: Jisheng Zhang <jszhang@marvell.com>, <ulf.hansson@linaro.org>,
        <rjui@broadcom.com>, <jonmason@broadcom.com>
References: <1453803963-6385-1-git-send-email-jszhang@marvell.com>
CC: <linux-mmc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <bcm-kernel-feedback-list@broadcom.com>,
        <linux-kernel@vger.kernel.org>
From: Scott Branden <sbranden@broadcom.com>
Message-ID: <56A824BF.3030202@broadcom.com>
Date: Tue, 26 Jan 2016 18:00:31 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1453803963-6385-1-git-send-email-jszhang@marvell.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jisheng,

Looks good.

Acked-by: Scott Branden <sbranden@broadcom.com>

On 16-01-26 02:26 AM, Jisheng Zhang wrote:
> The sdhci_iproc_remove() is jsut a wrapper to sdhci_pltfm_unregister.
> So use the sdhci_pltfm_unregister() for the .remove hook directly.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>   drivers/mmc/host/sdhci-iproc.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3b423b0..24c5546 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -220,11 +220,6 @@ err:
>   	return ret;
>   }
>
> -static int sdhci_iproc_remove(struct platform_device *pdev)
> -{
> -	return sdhci_pltfm_unregister(pdev);
> -}
> -
>   static struct platform_driver sdhci_iproc_driver = {
>   	.driver = {
>   		.name = "sdhci-iproc",
> @@ -232,7 +227,7 @@ static struct platform_driver sdhci_iproc_driver = {
>   		.pm = SDHCI_PLTFM_PMOPS,
>   	},
>   	.probe = sdhci_iproc_probe,
> -	.remove = sdhci_iproc_remove,
> +	.remove = sdhci_pltfm_unregister,
>   };
>   module_platform_driver(sdhci_iproc_driver);
>
>