From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
Andi Shyti <andi.shyti@samsung.com>
Cc: linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
rtc-linux@googlegroups.com, Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()
Date: Wed, 27 Jan 2016 11:05:36 +0900 [thread overview]
Message-ID: <56A825F0.9000108@samsung.com> (raw)
In-Reply-To: <56A82331.5050403@osg.samsung.com>
On 27.01.2016 10:53, Javier Martinez Canillas wrote:
> Hello Andi,
>
> Thanks a lot for your feedback and review.
>
> On 01/26/2016 10:22 PM, Andi Shyti wrote:
>> Hi Javier,
>>
>>> if (tm->tm_year < 100) {
>>> - pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
>>> - 1900 + tm->tm_year);
>>> + dev_warn(info->dev,
>>> + "RTC can't handle year %d. Assume it's 2000\n",
>>> + 1900 + tm->tm_year);
>>> return -EINVAL;
>>
>> Because we are returning an error value, why not use dev_err()?
>>
>
> You are absolutely right. Since the driver was using pr_warn(), I used
> dev_warn() but dev_err() would had been correct.
Wait. The message says that "2000 will be assumed" which is not an
error. The message indicates that driver will proceed, thus the warning.
However the driver won't proceed because the max77686_rtc_set_time()
will abort. This came from max8997 which has the same issue.
This means that either message should be changed (dev_err() without the
"assume" verb) or the function should not abort and set the year to
2000+something (then dev_warn()... look at rtc-ds3234.c and rtc-mcp795.c).
The easiest would be to choose #1 - no changes in the logic.
BR,
Krzysztof
next prev parent reply other threads:[~2016-01-27 2:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 19:20 [PATCH v3 00/10] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas
2016-01-26 19:20 ` [PATCH v3 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Javier Martinez Canillas
2016-01-27 1:19 ` Andi Shyti
2016-01-26 19:20 ` [PATCH v3 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas
2016-01-27 1:20 ` Andi Shyti
2016-01-26 19:20 ` [PATCH v3 03/10] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas
2016-01-27 1:21 ` Andi Shyti
2016-01-26 19:20 ` [PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas
2016-01-27 1:21 ` Andi Shyti
2016-01-27 1:47 ` Krzysztof Kozlowski
2016-01-26 19:20 ` [PATCH v3 05/10] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas
2016-01-27 1:53 ` Krzysztof Kozlowski
2016-01-26 19:20 ` [PATCH v3 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas
2016-01-27 1:59 ` Krzysztof Kozlowski
2016-01-27 2:24 ` Javier Martinez Canillas
2016-01-27 2:22 ` Andi Shyti
2016-01-26 19:20 ` [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas
2016-01-27 1:22 ` Andi Shyti
2016-01-27 1:53 ` Javier Martinez Canillas
2016-01-27 2:05 ` Krzysztof Kozlowski [this message]
2016-01-27 2:20 ` Javier Martinez Canillas
2016-01-27 2:35 ` Andi Shyti
2016-01-27 2:42 ` Javier Martinez Canillas
2016-01-27 2:46 ` Alexandre Belloni
2016-01-27 2:50 ` Javier Martinez Canillas
2016-01-27 2:12 ` Andi Shyti
2016-01-26 19:20 ` [PATCH v3 08/10] rtc: Remove Maxim 77802 driver Javier Martinez Canillas
2016-01-27 1:22 ` Andi Shyti
2016-01-27 2:09 ` Krzysztof Kozlowski
2016-01-26 19:20 ` [PATCH v3 09/10] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas
2016-01-26 19:20 ` [PATCH v3 10/10] ARM: multi_v7_defconfig: " Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A825F0.9000108@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andi.shyti@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox