From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753267AbcA0CGS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jan 2016 21:06:18 -0500
Received: from mailout3.w1.samsung.com ([210.118.77.13]:14423 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753071AbcA0CFp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jan 2016 21:05:45 -0500
X-AuditID: cbfec7f5-f79b16d000005389-d3-56a825f5a48e
Subject: Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()
To: Javier Martinez Canillas <javier@osg.samsung.com>,
        Andi Shyti <andi.shyti@samsung.com>
References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com>
 <1453836020-29579-8-git-send-email-javier@osg.samsung.com>
 <20160127012230.GE14296@samsunx.samsung> <56A82331.5050403@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
        rtc-linux@googlegroups.com, Chanwoo Choi <cw00.choi@samsung.com>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        linux-samsung-soc@vger.kernel.org
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
X-Enigmail-Draft-Status: N1110
Message-id: <56A825F0.9000108@samsung.com>
Date: Wed, 27 Jan 2016 11:05:36 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-version: 1.0
In-reply-to: <56A82331.5050403@osg.samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xK7pfVVeEGfy7zGXRcW0xk8X2I89Y
	La5/ec5q8ebtGiaL1y8MLfofv2a2WLpvNYvF5V1z2CxmnN/HZLG/s4PRgcvjyaaLjB57Jp5k
	89i0qpPNo7f5HZvHlv677B59W1YxenzeJBfAHsVlk5Kak1mWWqRvl8CV8WrnF6aC1VwVm+d8
	ZGxgvMrexcjBISFgInFzcnwXIyeQKSZx4d56ti5GLg4hgaWMEtMmLmWCcJ4ySvz5dZcFpEpY
	IEBi3YfTjCC2iECMxJ4b31khii4ySjxbvoYdxGEW6GGSWLLpCBNIFZuAscTm5UvYIHbISfR2
	TwKbxCugJTF58Swwm0VAVWLrjvesILaoQITE4c4udogaQYkfk++xgJzKKaAvcWmaIYjJLKAn
	cf+iFkgFs4C8xOY1b5knMArOQtIwC6FqFpKqBYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNz
	NzFCYuXrDsalx6wOMQpwMCrx8N7YvzxMiDWxrLgy9xCjBAezkghvj9KKMCHelMTKqtSi/Pii
	0pzU4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUw8ljXMtlZ1jNI+50XqVHJ9f0m
	NzU2Of7y6UMrp/VaBnQusLF/+V9z85/XVxjUVGL6DmzZ0ljIplkiZOz18+JR99+b2Tg3NT36
	cCzx/xL7witNpl//F9SYibotn3z21ZuXyW9XcCyY2v2+5JJF17rlhSmFu+/m9ulKxGjIee4M
	YnMuvHK89WO/EktxRqKhFnNRcSIAYD4DnZECAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27.01.2016 10:53, Javier Martinez Canillas wrote:
> Hello Andi,
> 
> Thanks a lot for your feedback and review.
> 
> On 01/26/2016 10:22 PM, Andi Shyti wrote:
>> Hi Javier,
>>
>>>           if (tm->tm_year < 100) {
>>> -            pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
>>> -                1900 + tm->tm_year);
>>> +            dev_warn(info->dev,
>>> +                 "RTC can't handle year %d. Assume it's 2000\n",
>>> +                 1900 + tm->tm_year);
>>>               return -EINVAL;
>>
>> Because we are returning an error value, why not use dev_err()?
>>
> 
> You are absolutely right. Since the driver was using pr_warn(), I used
> dev_warn() but dev_err() would had been correct.

Wait. The message says that "2000 will be assumed" which is not an
error. The message indicates that driver will proceed, thus the warning.

However the driver won't proceed because the max77686_rtc_set_time()
will abort. This came from max8997 which has the same issue.

This means that either message should be changed (dev_err() without the
"assume" verb) or the function should not abort and set the year to
2000+something (then dev_warn()... look at rtc-ds3234.c and rtc-mcp795.c).

The easiest would be to choose #1 - no changes in the logic.

BR,
Krzysztof