From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636AbcA0FV4 (ORCPT ); Wed, 27 Jan 2016 00:21:56 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37981 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413AbcA0FVu (ORCPT ); Wed, 27 Jan 2016 00:21:50 -0500 Subject: Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node To: Thierry Reding References: <1448884892-7731-1-git-send-email-architt@codeaurora.org> <1449751300-2841-1-git-send-email-architt@codeaurora.org> <1449751300-2841-7-git-send-email-architt@codeaurora.org> <20160121161638.GF647@ulmo.nvidia.com> Cc: dri-devel@lists.freedesktop.org, a.hajda@samsung.com, jani.nikula@linux.intel.com, linux-kernel@vger.kernel.org, airlied@linux.ie, daniel@ffwll.ch, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org From: Archit Taneja Message-ID: <56A853E8.2040105@codeaurora.org> Date: Wed, 27 Jan 2016 10:51:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160121161638.GF647@ulmo.nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2016 09:46 PM, Thierry Reding wrote: > On Thu, Dec 10, 2015 at 06:11:40PM +0530, Archit Taneja wrote: >> mipi_dsi_devices are inherently aware of their host because they >> share a parent-child hierarchy in the device tree. >> >> non-dsi drivers that create dsi device don't have this data. In order to >> get this information, they require to a phandle to the dsi host in the >> device tree. >> >> Maintain a list of all the hosts DSI that are currently registered. >> >> This list will be used to find the mipi_dsi_host corresponding to the >> device_node passed in of_find_mipi_dsi_host_by_node. >> >> Reviewed-by: Andrzej Hajda >> Signed-off-by: Archit Taneja >> --- >> drivers/gpu/drm/drm_mipi_dsi.c | 38 ++++++++++++++++++++++++++++++++++++++ >> include/drm/drm_mipi_dsi.h | 3 +++ >> 2 files changed, 41 insertions(+) > > Please be more consistent with the spelling. Abbreviations should be all > capitals. Also s/mipi_dsi_devices/MIPI DSI devices/, and so on. I'll ensure the abbreviations are consistent in the next revision. > > Otherwise I guess this makes sense. Thanks for the review. Thanks, Archit -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation