From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbcA0G6l (ORCPT ); Wed, 27 Jan 2016 01:58:41 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:48812 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756AbcA0G6i (ORCPT ); Wed, 27 Jan 2016 01:58:38 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: haibo.chen@freescale.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <1ef142884c23d0d39141e8cb3a002a74> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RFC PATCH 14/21] mmc: sdhci-esdhc-imx: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION To: Haibo Chen , Ulf Hansson References: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> <1453871318-3888-1-git-send-email-shawn.lin@rock-chips.com> Cc: shawn.lin@rock-chips.com, "bcm-kernel-feedback-list@broadcom.com" , "linux-rpi-kernel@lists.infradead.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dong Aisheng , Haibo Chen From: Shawn Lin Message-ID: <56A86A7E.6090602@rock-chips.com> Date: Wed, 27 Jan 2016 14:58:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/27 14:54, Haibo Chen wrote: > Hi Shawn, > > Comments below. > [...] >> return ret; >> >> if (!IS_ERR_VALUE(mmc_gpio_get_cd(host->mmc))) >> - host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> + host->mmc->caps &= MMC_CAP_NEEDS_POLL; > > You miss ' ~', seems you need to change to: > host->mmc->caps &=~ MMC_CAP_NEEDS_POLL; > Thanks for pointing out. I will fix this for the next version. >> >> return 0; >> } >> @@ -1064,7 +1063,7 @@ static int sdhci_esdhc_imx_probe_nondt(struct >> platform_device *pdev, >> >> case ESDHC_CD_CONTROLLER: >> /* we have a working card_detect back */ >> - host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION; >> + host->mmc->caps &= MMC_CAP_NEEDS_POLL; > > The same issue. > >> break; >> >> case ESDHC_CD_PERMANENT: >> @@ -1104,6 +1103,8 @@ static int sdhci_esdhc_imx_probe(struct >> platform_device *pdev) >> if (IS_ERR(host)) >> return PTR_ERR(host); >> >> + host->mmc->caps |= MMC_CAP_NEEDS_POLL; >> + >> pltfm_host = sdhci_priv(host); >> >> imx_data = devm_kzalloc(&pdev->dev, sizeof(*imx_data), >> GFP_KERNEL); >> -- >> 2.3.7 >> > > > > -- Best Regards Shawn Lin