From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055AbcA0IPY (ORCPT ); Wed, 27 Jan 2016 03:15:24 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:51610 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbcA0IPV (ORCPT ); Wed, 27 Jan 2016 03:15:21 -0500 Subject: Re: [PATCH v2] mmc: omap_hsmmc: don't print uninitialized variables To: Arnd Bergmann , Ulf Hansson References: <3411189.gO0215GrNM@wuerfel> CC: , Kishon Vijay Abraham I , Andreas Fenkart , Tony Lindgren , Roger Quadros , , , From: Peter Ujfalusi Message-ID: <56A87C74.2010905@ti.com> Date: Wed, 27 Jan 2016 10:14:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <3411189.gO0215GrNM@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2016 05:26 PM, Arnd Bergmann wrote: > When DT based probing is used but the DMA request fails, the > driver will print uninitialized stack data from the rx_req > and tx_req variables, as indicated by this warning: > > drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_probe': > drivers/mmc/host/omap_hsmmc.c:2162:3: warning: 'rx_req' may be used uninitialized in this function [-Wmaybe-uninitialized] > dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", rx_req); > > This removes the DMA request line number from the warning, which > is the easiest solution and won't hurt us any more as we are > planning to remove the legacy code path anyway. > > Signed-off-by: Arnd Bergmann > --- > A simpler patch as v1 with the same result, as suggested by Peter Ujfalusi. Reviewed-by: Peter Ujfalusi > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index b6639ea0bf18..87f0d840a166 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -2159,7 +2159,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) > &rx_req, &pdev->dev, "rx"); > > if (!host->rx_chan) { > - dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", rx_req); > + dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel\n"); > ret = -ENXIO; > goto err_irq; > } > @@ -2169,7 +2169,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) > &tx_req, &pdev->dev, "tx"); > > if (!host->tx_chan) { > - dev_err(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", tx_req); > + dev_err(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel\n"); > ret = -ENXIO; > goto err_irq; > } > -- Péter