From: "Li, Weigang" <weigang.li@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Joonsoo Kim <js1304@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Minchan Kim <minchan@kernel.org>,
Dan Streetman <ddstreet@ieee.org>, <linux-crypto@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support
Date: Wed, 27 Jan 2016 16:26:16 +0800 [thread overview]
Message-ID: <56A87F28.9050101@intel.com> (raw)
In-Reply-To: <20160127080926.GA31516@gondor.apana.org.au>
On 1/27/2016 4:09 PM, Herbert Xu wrote:
> On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote:
>> On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote:
>>>
>>> The acomp is also SG-based, while scomp only accepts flat buffer.
>>
>> Right, but do we need a pointer-based scomp at all? IPComp would
>> certainly be better off with an SG-based interface. Any other
>> users of compression are presumably dealing with large amounts
>> of data where an SG interface would make more sense.
>>
>> A pointer interface makes sense for shash because you may be hashing
>> 16 bytes at a time. Nobody sane is going to be compressing 16 bytes,
>> or are they?
>
> Note that I'm fine with keeping an scomp interface underneath
> for those algorithms where the best way to handle SG input is
> to linearise things. But I would prefer that this interface is
> not exposed to kernel users unless it is absolutely required.
>
> Cheers,
>
Thanks for your comments, Herbert. I Agree, SG-list based compression
API makes more sense. Maybe Joonsoo can comment on this.
next prev parent reply other threads:[~2016-01-27 8:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 8:15 [PATCH v2 00/10] Introduce new async/sync compression APIs Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 01/10] crypto/compress: remove unused pcomp interface Joonsoo Kim
2016-01-27 14:17 ` Herbert Xu
2016-01-26 8:15 ` [PATCH v2 02/10] crypto: add algorithm type specific flag, CRYPTO_ALG_PRIVATE Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 03/10] crypto/compress: introduce sychronuous compression API Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 04/10] crypto/compress: add asynchronous compression support Joonsoo Kim
2016-01-27 7:41 ` Herbert Xu
2016-01-27 7:59 ` Li, Weigang
2016-01-27 8:03 ` Herbert Xu
2016-01-27 8:09 ` Herbert Xu
2016-01-27 8:26 ` Li, Weigang [this message]
2016-01-28 3:19 ` Joonsoo Kim
2016-01-29 10:09 ` Herbert Xu
2016-02-01 2:11 ` Joonsoo Kim
2016-02-04 3:25 ` Li, Weigang
2016-02-04 3:28 ` Herbert Xu
2016-02-04 3:29 ` Herbert Xu
2016-02-04 3:50 ` Li, Weigang
2016-02-04 14:56 ` Herbert Xu
2016-02-04 7:17 ` Joonsoo Kim
2016-02-04 14:53 ` Herbert Xu
2016-02-04 16:19 ` Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 05/10] crypto/lzo: support new compression APIs Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 06/10] crypto/lz4: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 07/10] crypto/lz4hc: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 08/10] crypto/842: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 09/10] crypto/deflate: " Joonsoo Kim
2016-01-26 8:15 ` [PATCH v2 10/10] crypto/testmgr: add new compression APIs test Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A87F28.9050101@intel.com \
--to=weigang.li@intel.com \
--cc=davem@davemloft.net \
--cc=ddstreet@ieee.org \
--cc=herbert@gondor.apana.org.au \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).