From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934025AbcA0QfU (ORCPT ); Wed, 27 Jan 2016 11:35:20 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:52318 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933917AbcA0QfO (ORCPT ); Wed, 27 Jan 2016 11:35:14 -0500 Subject: Re: [PATCH 2/2] gpio: davinci: use irq_data_get_chip_type To: Linus Walleij , Geliang Tang , Santosh Shilimkar , Sekhar Nori References: <4cc3a3a7a74c7a1894892a85aa7eabbd1534fe96.1451484758.git.geliangtang@163.com> CC: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Grygorii Strashko Message-ID: <56A8F1B6.20401@ti.com> Date: Wed, 27 Jan 2016 18:35:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/27/2016 03:56 PM, Linus Walleij wrote: > On Wed, Dec 30, 2015 at 3:16 PM, Geliang Tang wrote: > >> Use irq_data_get_chip_type() instead of container_of(). >> >> Signed-off-by: Geliang Tang >> --- >> drivers/gpio/gpio-davinci.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index 65ebaef..aaa1a249 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -435,8 +435,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq) >> { >> static struct irq_chip_type gpio_unbanked; >> >> - gpio_unbanked = *container_of(irq_get_chip(irq), >> - struct irq_chip_type, chip); >> + gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq)); >> >> return &gpio_unbanked.chip; >> }; > > Grygorii/Santosh, can you ACK/comment on this patch? > Reviewed-by: Grygorii Strashko -- regards, -grygorii