From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S968061AbcA0U7h (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jan 2016 15:59:37 -0500
Received: from mail-wm0-f65.google.com ([74.125.82.65]:36188 "EHLO
	mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965371AbcA0U7c (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jan 2016 15:59:32 -0500
Subject: Re: [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver
To: Linus Walleij <linus.walleij@linaro.org>
References: <1452773795-24216-1-git-send-email-mcoquelin.stm32@gmail.com>
 <CACRpkdYGQ1xObWfka2CN9au6YMGhpu4qcTZpu72bzuJjO38tog@mail.gmail.com>
Cc: Patrice CHOTARD <patrice.chotard@st.com>,
        Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh+dt@kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Bruno Herrera <bruherrera@gmail.com>
From: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Message-ID: <56A92FB0.7080907@gmail.com>
Date: Wed, 27 Jan 2016 21:59:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <CACRpkdYGQ1xObWfka2CN9au6YMGhpu4qcTZpu72bzuJjO38tog@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/27/2016 02:20 PM, Linus Walleij wrote:
> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
> <mcoquelin.stm32@gmail.com>  wrote:
>
>> >This is the fourth round of STM32 pinctrl series, which takes into
>> >account comments made by Patrice on patch 4.
> I have applied patch 2 and 4 to the pinctrl tree.

Just tried to compile your devel branch, and it breaks:

   CC      drivers/pinctrl/stm32/pinctrl-stm32f429.o
drivers/pinctrl/stm32/pinctrl-stm32.c: In function 
'stm32_gpiolib_register_bank':
drivers/pinctrl/stm32/pinctrl-stm32.c:692:17: error: 'struct gpio_chip' 
has no member named 'dev'
   bank->gpio_chip.dev = dev;
                  ^
make[3]: *** [drivers/pinctrl/stm32/pinctrl-stm32.o] Error 1

This is due to the field renaming you did in gpio_chip struct:
58383c7 gpio: change member .dev to .parent

How do you prefer to proceed?
Should I send a fix on top of your devel branch, or you will fix it 
directly?

Thanks,
Maxime