From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935091AbcA1Gms (ORCPT ); Thu, 28 Jan 2016 01:42:48 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:11150 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934583AbcA1Gmn (ORCPT ); Thu, 28 Jan 2016 01:42:43 -0500 X-AuditID: cbfec7f5-f79b16d000005389-2e-56a9b86195f2 Subject: Re: [PATCH V5 5/5] regulator: max77620: add regulator driver for max77620/max20024 To: Laxman Dewangan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com References: <1453903808-29788-1-git-send-email-ldewangan@nvidia.com> <1453903808-29788-6-git-send-email-ldewangan@nvidia.com> <56A99130.1070904@samsung.com> <56A9B41C.4070607@nvidia.com> Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, Mallikarjun Kasoju From: Krzysztof Kozlowski Message-id: <56A9B85C.2050206@samsung.com> Date: Thu, 28 Jan 2016 15:42:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <56A9B41C.4070607@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t/xy7qJO1aGGax+xmSx5OJVdouOa4uZ LKY+fMJmMf/IOVaL/jcLWS3OvXrEAiRWMlq8fmFosXTfahaL+1+PMlp8u9LBZDHlz3Imi83z /zBaXN41h81i6fWLTBb39q5gs5gwfS2LReveI+wW+zs7GC1uTG9htbj9m89B1GPNvDWMHpf7 epk8nmy6yOixc9Zddo89E0+yeaxc/oXNY9OqTjaPO9f2sHn0Nr9j8+jbsorRY/q8n0wenzfJ BfBEcdmkpOZklqUW6dslcGX8eXWLpWAGf8XkpiesDYzzeboYOTkkBEwk9t7czgxhi0lcuLee rYuRi0NIYCmjRFPDXiYI5ymjxPE/t1hBqoQFYiXaH81iBEmICGxnkth04xkjRNU+Rokbx+6x gjjMAg8YJeZMeQ02mE3AWGLz8iVsIDavgJbEg5YdjCA2i4CqxJ2lh8DiogIREoc7u9ghagQl fky+xwJicwLVNyzdBmRzAA3Vk7h/UQskzCwgL7F5zVvmCYwCs5B0zEKomoWkagEj8ypG0dTS 5ILipPRcI73ixNzi0rx0veT83E2MkLj9uoNx6TGrQ4wCHIxKPLwMUSvDhFgTy4orcw8xSnAw K4nwKlYDhXhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REggPbEkNTs1tSC1CCbLxMEp1cDY W/1RzOCGt9OZ8up1/u83mVkd/c1hu0PCoSu74NjDFat2rtDMdSgvXFLEMWf3Rb6GsvzXU6Ld 47JLO1TUeV6+WnA9QfTqCd2pc3LueZeaO3FHFkf8uZapx514repl25SCLadel2Tfie1Mivxy /8/SE/W8CjuSkhy7mbOf8H/rn/wyxaePSVKJpTgj0VCLuag4EQDIjtbV1wIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.01.2016 15:24, Laxman Dewangan wrote: > > On Thursday 28 January 2016 09:25 AM, Krzysztof Kozlowski wrote: >> On 27.01.2016 23:10, Laxman Dewangan wrote: >>> MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the >>> multiple DCDC and LDOs. This supplies the power to different >>> components of the system. >>> Also these rails has configuration for ramp time, flexible >>> power sequence, slew rate etc. >>> >>> Add regulator driver to access these rails via regulator APIs. >>> >>> Signed-off-by: Laxman Dewangan >>> Signed-off-by: Mallikarjun Kasoju >>> --- >>> Changes from V1: >>> - Cleanup code based on comment received on mfd/rtc. >>> - Avoid duplication on error message. >>> >>> Changes form V2: >>> - Run coccicheck and checkpatch in strict mode for the alignment. >>> - Refactor Regulator driver to use core API for DT parsing. >>> - Update based on API changes. >>> >>> Changes from V3: >>> - Change all sys initcall to module driver. >>> - change the max77620_read argument to unisgned int from u8. >>> >>> Changes from V4: >>> - Added DT binding document as >>> devicetree/bindings/regulator/regulator-max77620.txt >>> - Detail out properties. >> What does it mean "Detail out properties"? What have changed> > > Based on review comment from Linus W, I added more description on the > properties. Ah, ok. >> I already reviewed the patchset but because of adding bindings here, you >> could not add my reviewed-by tag (which makes my effort not tracked...). > Yaah, This patch include the dt binding and so wanted your review again. > This si only reason to not add reviewed-by. > > Now I am going to separate out DT binding and driver, I will add > reviewed-by tag for you in driver file. Yeah, but the driver nor the bindings do not change so it really does not need my additional review. Best regards, Krzysztof