From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934362AbcA1JtT (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 Jan 2016 04:49:19 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:41041 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933420AbcA1JtO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 Jan 2016 04:49:14 -0500
Subject: Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver
To: Lee Jones <lee.jones@linaro.org>
References: <1452514817-118311-1-git-send-email-puck.chen@hisilicon.com>
 <1452514817-118311-4-git-send-email-puck.chen@hisilicon.com>
 <20160125142253.GP3368@x1>
CC: <linux-kernel@vger.kernel.org>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <yudongbin@hisilicon.com>,
        <saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
        <kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
        <z.liuxinliang@hisilicon.com>, <puck.chenfeng@gmail.com>,
        <weidong2@hisilicon.com>, <w.f@huawei.com>, <qijiwen@hisilicon.com>,
        <peter.panshilin@hisilicon.com>, <dan.zhao@hisilicon.com>,
        <linuxarm@huawei.com>, <liguozhu@hisilicon.com>
From: chenfeng <puck.chen@hisilicon.com>
Message-ID: <56A9E405.1080808@hisilicon.com>
Date: Thu, 28 Jan 2016 17:48:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20160125142253.GP3368@x1>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.192.172]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020201.56A9E416.00AF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 738443134deb49ce1b435b785afa0f48
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

Thanks for your review!
There is one things need your confirm.
Please help to see it below.

On 2016/1/25 22:22, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
> 
>> Add pmic mfd driver to support hisilicon hi665x.
[..]

> 
>> +static const struct mfd_cell hi655x_pmic_devs[] = {
>> +	{ .name = "hi655x-regulator", },
>> +};
> 
> What other devices are there?
> 

Current the MFD PMIC driver only has regulator enable.

The RTC & Power-key are not in these patch sets.

They will be added later.

Will this be accepted?

>> +static const struct regmap_irq hi655x_irqs[] = {
>> +	{ .reg_offset = 0, .mask = OTMP_D1R_INT },