From: Prarit Bhargava <prarit@redhat.com>
To: Vasily Averin <vvs@virtuozzo.com>, linux-kernel@vger.kernel.org
Cc: John Stultz <john.stultz@linaro.org>,
Xunlei Pang <pang.xunlei@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Baolin Wang <baolin.wang@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.cz>, Tejun Heo <tj@kernel.org>,
Peter Hurley <peter@hurleysoftware.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] printk, allow different timestamps for printk.time [v2]
Date: Thu, 28 Jan 2016 08:17:42 -0500 [thread overview]
Message-ID: <56AA14F6.7060802@redhat.com> (raw)
In-Reply-To: <56AA0F16.1020806@virtuozzo.com>
On 01/28/2016 07:52 AM, Vasily Averin wrote:
> Dear Prarit,
>
Hi Vasily, Thanks for your suggestions.
> I have no objections about your patch,
> bit in fact I doubt we really need to convert each timestamp in kernel logs.
> How do you think is it probably better to convert only one timestamp per screen ?
How do you measure a screen? :)
> I.e. convert it in each 25th string only?
While your suggestion does work for a flood of messages this will miss
situations where an event occurred hours/minutes/seconds earlier leading to a
panic.
> Or just do it once per N seconds?
I've tried several other versions of the patch and other userspace options (such
as "date +%N > /tmp/kmsg" every second, setting up a timer to dump the real
time, etc.). Assuming that the disks didn't die (which was also part of the
problem I have seen) the printk buffer is finite in size and it is easy to fill
the buffer if you're not careful.
> And do not replace original timestamp but add converted one?
I'm not sure I see the benefit of having two timestamps but if someone really
wanted that I could add an additional patch to do it.
At the end of the day I need to be able to determine in real time what happened
on a system and to make that as easy as possible for a human to read.
P.
next prev parent reply other threads:[~2016-01-28 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 12:43 [PATCH] printk, allow different timestamps for printk.time [v2] Prarit Bhargava
2016-01-28 12:52 ` Vasily Averin
2016-01-28 13:17 ` Prarit Bhargava [this message]
2016-01-28 13:49 ` Vasily Averin
2016-02-04 16:48 ` Petr Mladek
2016-02-04 17:03 ` Prarit Bhargava
2016-02-08 15:51 ` Petr Mladek
2016-02-08 16:05 ` Prarit Bhargava
2016-02-04 17:25 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA14F6.7060802@redhat.com \
--to=prarit@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=peter@hurleysoftware.com \
--cc=pmladek@suse.cz \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).