From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753409AbcA2IRu (ORCPT ); Fri, 29 Jan 2016 03:17:50 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33058 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751811AbcA2IRs (ORCPT ); Fri, 29 Jan 2016 03:17:48 -0500 Subject: Re: [PATCH v4 2/4] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts To: "Wu, Feng" , =?UTF-8?Q?Radim_Krcm=c3=a1r?= References: <1453712015-3989-1-git-send-email-feng.wu@intel.com> <1453712015-3989-3-git-send-email-feng.wu@intel.com> <20160126185909.GE21252@potion.brq.redhat.com> Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" From: Paolo Bonzini Message-ID: <56AB2026.5010103@redhat.com> Date: Fri, 29 Jan 2016 09:17:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/01/2016 02:51, Wu, Feng wrote: > > >> -----Original Message----- >> From: Radim Krčmář [mailto:rkrcmar@redhat.com] >> Sent: Wednesday, January 27, 2016 2:59 AM >> To: Wu, Feng >> Cc: pbonzini@redhat.com; linux-kernel@vger.kernel.org; kvm@vger.kernel.org >> Subject: Re: [PATCH v4 2/4] KVM: x86: Use vector-hashing to deliver lowest- >> priority interrupts >> >> 2016-01-25 16:53+0800, Feng Wu: >>> Use vector-hashing to deliver lowest-priority interrupts, As an >>> example, modern Intel CPUs in server platform use this method to >>> handle lowest-priority interrupts. >>> >>> Signed-off-by: Feng Wu >>> --- >> >> With any proposed resolution of BUG_ON in kvm_vector_to_index, >> >> Reviewed-by: Radim Krčmář >> >>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >>> @@ -123,6 +123,9 @@ module_param(tsc_tolerance_ppm, uint, S_IRUGO | >> S_IWUSR); >>> +bool __read_mostly vector_hashing = true; >> >> (Module param can be static.) >> >>> +module_param(vector_hashing, bool, S_IRUGO); > > Thanks a lot for your comments, Radim & Paolo! > > Paolo, given that the only two comments above, do I need to send v5? Or > you can handle it while merging them? I am fine with both methods. It's fine, I'm merging it. Paolo