From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755706AbcA2IuF (ORCPT ); Fri, 29 Jan 2016 03:50:05 -0500 Received: from mout.gmx.net ([212.227.17.22]:61587 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656AbcA2IuB (ORCPT ); Fri, 29 Jan 2016 03:50:01 -0500 Subject: Re: [PATCH] irqchip: mxs: add missing set_handle_irq() To: Thomas Gleixner References: <1454056195-23105-1-git-send-email-linux@rempel-privat.de> Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com From: Oleksij Rempel X-Enigmail-Draft-Status: N1110 Message-ID: <56AB2784.2090205@rempel-privat.de> Date: Fri, 29 Jan 2016 09:49:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FBWRgm23U4QeQ4hsa5widw2uJp0t0HXtB" X-Provags-ID: V03:K0:TnB+aofLYruVULNIWVlEGylVZgZSxG+AeqWeSEplUeTCi0/aUNS nAa8cyyWa0v0sQVvL6SOl/qdZGh7r9jw2arRU+P0mt2EXAZdKV6xUL/LyKhJBtHULClUviF 1a1Iw1+mUEmsGsRb+6DYyJjZtb721PechNvHUkGTD/n8ZAr03HKPRI3w1nRMtZVuMRXQZjx pUmoFWuXpT85+6pa3Dwgw== X-UI-Out-Filterresults: notjunk:1;V01:K0:NDfwXegXHBQ=:CKNIsBX+bzjc57VFR/5LVB uzNegscQuEitXeT2Z1Fyo/JuChsI0a6WUa8hp5KZCAgNVa/vUzU0e7UaWLtH80h90Y9uj6KCx ClcQ2QgEz1nSIvdOrz8OTz1A+X43aB5VhiKCd2TwahDZiMofTD4DL26Ff/g36p2bZRTObPIl6 AV9McLJUcDdcqKIWd5kiwpILXaKAbcUb5Lutg/w//HfXXqw4aXnTgL0Q19sWyRhOuMi9nRdd9 xW9N9Ic6RFTEo4nhBGTBILq/xoYjs74RKisOqNskpHn1cyoiloQzJMUwDowHYB52VG4G0C3WF wVoL6R3oPQa1i2Xh/UE0UVDW3el4xLGwa5fF+XH0Jbqi4uX1PJdJwy4i8SAGCGy9coTrtw46h RCPQ0ecKDhrZJ6WDY2qn2DiVNYOJv3cAI7iaa0kqyiuToGI4Ipfic/6mWKkgVoPRHJKPc2AAQ vS2KkVjHFcaa2bMAl37+UoZvj0LYAB3sVHzMkoO9QaE2hr1EMWBadbXweEykd3GOJ9d7ODx0m lY3YYy8qxjWBUCFBXgo+XXWrFrG+UF3XQvldgGaEBoMwCgS7RKyPdi5cH2rzwdcUHfOqrg2J5 +1CuxzF5xMaE+MtcSImPG2oaD20EgPUO4TaHj8Q7z89vIjvCvYHxksOAFsnmooxJwYGnA6jw8 gqvACOeXxTNbJWtOhU0PFq83if1jLiV5bKzmBWtQjKzvh/XfSeEyrUTgTpIwD3TsKm+TSZyS3 ggdGdzDwRVUB2sW3zuH6MC4wryrMtZUEOyqhVMxAprJaVyit2GTvvda8SOg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FBWRgm23U4QeQ4hsa5widw2uJp0t0HXtB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 29.01.2016 um 09:33 schrieb Thomas Gleixner: > On Fri, 29 Jan 2016, Oleksij Rempel wrote: >=20 >> this will fix IRQ related issues on Alphascale ASM9260 >=20 > This really does not qualify as a changelog. >=20 > 1) What's the problem and what consequences does it have >=20 > 2) What's the fix. >=20 > Thanks, >=20 > tglx >=20 The driver provide this function: asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *re= gs) { u32 irqnr; irqnr =3D __raw_readl(icoll_priv.stat); __raw_writel(irqnr, icoll_priv.vector); handle_domain_irq(icoll_domain, irqnr, regs); } i assume at some late review point instead of move it to asm9260_of_init i removed it completely. As result, the driver was compilable but not working. Should i put this explanation to changelog? --=20 Regards, Oleksij --FBWRgm23U4QeQ4hsa5widw2uJp0t0HXtB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlarJ48ACgkQHwImuRkmbWl4dgD8DJlKeg+NKOX1VUnKu/FBB0pF jy6Ke2IGC9LgcTXcT70A/RSV4yQUmaU12cBGlUIdfv0UWhREwKU5VzxvlPXnZuQG =wary -----END PGP SIGNATURE----- --FBWRgm23U4QeQ4hsa5widw2uJp0t0HXtB--