From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754985AbcA2I7D (ORCPT ); Fri, 29 Jan 2016 03:59:03 -0500 Received: from mout.gmx.net ([212.227.15.19]:57120 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753403AbcA2I7B (ORCPT ); Fri, 29 Jan 2016 03:59:01 -0500 Subject: Re: [PATCH] irqchip: mxs: add missing set_handle_irq() To: Thomas Gleixner References: <1454056195-23105-1-git-send-email-linux@rempel-privat.de> <56AB2784.2090205@rempel-privat.de> Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com From: Oleksij Rempel Message-ID: <56AB29C4.8060304@rempel-privat.de> Date: Fri, 29 Jan 2016 09:58:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dJJAAs78P0v7g4qCiRpC5iF5a0vKnEuSn" X-Provags-ID: V03:K0:xeRp+V3pmxFEQIKRRai+V6IkeYmZ0WXfDfSvvHEGwhgocupRQuc azPv5LZFErAdBgt4KSoYEL8ENv7EAp6J60oOhhac2d3Vpw/tufZAgv0mhZl/GlhgGNCFBPn mfHF+5sXEEvxPvYEEbk9jaoYyepZ5EHCAasrK9oR3QF1KpK5mzdlN+uV2K6mIZD0wVxRzWC 0EUB470Y80yrPkuzTlwQg== X-UI-Out-Filterresults: notjunk:1;V01:K0:GQ6a1WCD448=:YZzAox8W8+skvZqgi4lVoI Im1TR6OBOkjzLZQX2LFyLUP4sRoL7CiNzWBwt2AN/6dRbqmIm13SCqFCd4m8GE2xoFAZtIrw7 wMd/C0R01Q2iaAsr9VcgDoAWXUEpGp6bVP1IyE9uRMmJqw6AlrAOfTWxv7RcjwNnswNXOiIe7 +psD2yeAmia5YOdWfCsA71QH5qEZWhjkCEWqQ+jtddZNVTN6swN0CDb1lhvIvZj6Tf1GDQk31 VeQGJpD3LI/h1omKekI8Bmgo3UHillHFmmzkew7TDqAm2iBl2h/3Tc/zh+zAKNRwWeJEhR/rQ 7E2dceDyZ4BZN5avmyI7HkB0qAKAIjX90ECn2hm9DaC9LvUopTUhQYuIqdF7zbCaGRROBEDRs SKv/4uWkVYcFAxXN+M7N4Frh9dC8cZVzwLGgOWImA5vAvdNN5JyBgxHKAzrq0yAa2fF718OFB Egep5EXrUkTh/OCuHgF1cjQf83luoxI+7Mbekv48auHoeO2N0pxMyKo5RyHjLSj9RvHRrZTJ7 fw68uxcZ0Qt3UfD6qUkgvR6iJyW4bf85iuhvyE5rvnqE3ELUiW5EIHJSZYV5lxouoA6/LmvVf +EKJwiXNIF3hs8RWAuFgSPsE3MxafnnbHC+HBMXVGrg7KHS97EHY/mTU2Tco/+hVZbiGlV9wv jTg1KiP0y5mBd/EJEAMDKE4XpWpUbhoQmFVIpDFKD5tc2Yv7xjs4tMUG3ZMZuQLNrqKYKuTVd K8vQShOBX+ktDjiIQl7o29HpSTSeqY2XsFPU9dhEnwDRWBCGTQa87zjBioQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dJJAAs78P0v7g4qCiRpC5iF5a0vKnEuSn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 29.01.2016 um 09:54 schrieb Thomas Gleixner: > On Fri, 29 Jan 2016, Oleksij Rempel wrote: >> Am 29.01.2016 um 09:33 schrieb Thomas Gleixner: >>> On Fri, 29 Jan 2016, Oleksij Rempel wrote: >>> >>>> this will fix IRQ related issues on Alphascale ASM9260 >>> >>> This really does not qualify as a changelog. >>> >>> 1) What's the problem and what consequences does it have >>> >>> 2) What's the fix. >>> >>> Thanks, >>> >>> tglx >>> >> >> The driver provide this function: >> asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs = *regs) >> { >> u32 irqnr; >> >> irqnr =3D __raw_readl(icoll_priv.stat); >> __raw_writel(irqnr, icoll_priv.vector); >> handle_domain_irq(icoll_domain, irqnr, regs); >> } >> >> i assume at some late review point instead of move it to asm9260_of_in= it >> i removed it completely. As result, the driver was compilable but not >> working. >> Should i put this explanation to changelog? >=20 > So the problem is: >=20 > The rework of the driver missed to move the call to set_handle_irq() in= to > asm9260_of_init(). As a consequence no interrupt entry point is install= ed and > no interrupts are delivered (or whatever the outcome is, crash, explode= ...) >=20 > Solution is: >=20 > Install the interrupt entry handler. >=20 > Right? Right. Should i resend a patch with new comment? > And that wants a tag: >=20 > Fixes: nnnnnnnnnnnn ("irqchip/......") >=20 > So we can mark it for stable. >=20 > Thanks, >=20 > tglx >=20 --=20 Regards, Oleksij --dJJAAs78P0v7g4qCiRpC5iF5a0vKnEuSn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlarKcQACgkQHwImuRkmbWkh8QD+LfhDFdzIhIQDjxEnS/a6hZ9y vBHJHOIjBeWKf5Vr5vUA/01Dy4/Ji+Hk7cmXtEjfrGYBTD9AgGDYVBVrAmlGqUl6 =fgaC -----END PGP SIGNATURE----- --dJJAAs78P0v7g4qCiRpC5iF5a0vKnEuSn--