From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755585AbcA3Cxq (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 21:53:46 -0500
Received: from szxga01-in.huawei.com ([58.251.152.64]:55059 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753728AbcA3Cxo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 21:53:44 -0500
Subject: Re: [PATCH 03/15] mips: use of_platform_default_populate() to
 populate default bus
To: Joshua Henderson <joshua.henderson@microchip.com>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
References: <1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com>
 <1453868872-26300-4-git-send-email-wangkefeng.wang@huawei.com>
 <56AB8CA4.7070803@microchip.com>
CC: Arnd Bergmann <arnd@arndb.de>, Shawn Guo <shawnguo@kernel.org>,
        "Russell King" <linux@arm.linux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, Rob Herring <robh+dt@kernel.org>,
        "Masahiro Yamada" <yamada.masahiro@socionext.com>,
        <guohanjun@huawei.com>, Ralf Baechle <ralf@linux-mips.org>
From: Kefeng Wang <wangkefeng.wang@huawei.com>
Message-ID: <56AC256C.2050304@huawei.com>
Date: Sat, 30 Jan 2016 10:52:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <56AB8CA4.7070803@microchip.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.19.180]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.56AC2579.010F,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 65fc70ccf418b568bdf2bbc8c436c24b
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/1/30 0:00, Joshua Henderson wrote:
> On 01/26/2016 09:27 PM, Kefeng Wang wrote:
>> Use helper of_platform_default_populate() in linux/of_platform
>> when possible, instead of calling of_platform_populate() with
>> the default match table.
>>
>> Cc: Ralf Baechle <ralf@linux-mips.org>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>  arch/mips/ath79/setup.c           | 2 +-
>>  arch/mips/jz4740/setup.c          | 2 +-
>>  arch/mips/mti-sead3/sead3-setup.c | 2 +-
>>  arch/mips/pic32/pic32mzda/init.c  | 3 +--
>>  arch/mips/pistachio/init.c        | 2 +-
>>  arch/mips/xilfpga/init.c          | 2 +-
>>  6 files changed, 6 insertions(+), 7 deletions(-)
>>
> 
> [...]
> 
>> diff --git a/arch/mips/pic32/pic32mzda/init.c b/arch/mips/pic32/pic32mzda/init.c
>> index 775ff90..77ecf32 100644
>> --- a/arch/mips/pic32/pic32mzda/init.c
>> +++ b/arch/mips/pic32/pic32mzda/init.c
>> @@ -147,8 +147,7 @@ static int __init plat_of_setup(void)
>>  		panic("Device tree not present");
>>  
>>  	pic32_of_prepare_platform_data(pic32_auxdata_lookup);
>> -	if (of_platform_populate(NULL, of_default_bus_match_table,
>> -				 pic32_auxdata_lookup, NULL))
>> +	if (of_platform_default_populate(NULL, pic32_auxdata_lookup, NULL))
>>  		panic("Failed to populate DT");
>>  
>>  	return 0;
> 
> I'll one-up just compile-testing for this.

Hi Joshua, Many thanks.

> 
> Tested-by: Joshua Henderson <joshua.henderson@microchip.com>
> 
> [...]
> 
> 
> .
>