linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caesar Wang <caesar.upstream@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Caesar Wang <wxt@rock-chips.com>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, hl@rock-chips.com,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	sonnyrao@chromium.org, jeffy.chen@rock-chips.com,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Mark Brown <broonie@kernel.org>,
	keescook@google.com, cf@rock-chips.com,
	Kumar Gala <galak@codeaurora.org>,
	jay.xu@rock-chips.com, leozwang@google.com,
	Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v4 6/9] ASoC: rt5616: add mclk property for rt5616 document
Date: Sun, 31 Jan 2016 17:09:51 +0800	[thread overview]
Message-ID: <56ADCF5F.1010203@gmail.com> (raw)
In-Reply-To: <20160129162800.GA10835@rob-hp-laptop>


在 2016年01月30日 00:28, Rob Herring 写道:
> On Thu, Jan 28, 2016 at 04:43:35PM +0800, Caesar Wang wrote:
>> This patch add the mclk property for the CODEC driver,
>> since sometime the CODEC driver needs the clock enabled.
> s/add/adds/
>
> s/sometime/sometimes/

Done, thanks for pointing out that.


>> The system clock of ALC5616 can be selected from MCLK,
>> That's also make as the codec master clock provider,
> That also makes the codec the master clock provider.
>

Ditto.

>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>>
>> ---
>>
>> Changes in v4:
>> - Add this patch included in kylin series patches.
>>
>>   Documentation/devicetree/bindings/sound/rt5616.txt | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt
>> index efc48c6..e410858 100644
>> --- a/Documentation/devicetree/bindings/sound/rt5616.txt
>> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
>> @@ -8,6 +8,12 @@ Required properties:
>>   
>>   - reg : The I2C address of the device.
>>   
>> +Optional properties:
>> +
>> +- clocks: The phandle of the master clock to the CODEC.
>> +
>> +- clock-names: Should be "mclk".
>> +
>>   Pins on the device (for linking into audio routes) for RT5616:
>>   
>>     * IN1P
>> -- 
>> 1.9.1
>>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


-- 
Thanks,
Caesar

  reply	other threads:[~2016-01-31  9:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  8:43 [PATCH v4 0/9] Add the family patches to support for kylin board Caesar Wang
2016-01-28  8:43 ` [PATCH v4 1/9] ARM: dts: rockchip: add the leds control " Caesar Wang
2016-01-31 10:46   ` Heiko Stuebner
2016-02-01  6:40     ` Caesar Wang
2016-01-28  8:43 ` [PATCH v4 2/9] ARM: dts: rockchip: add hdmi/vop device node for rk3036 Caesar Wang
2016-01-28  8:43 ` [PATCH v4 3/9] clk: rockchip: rk3036: fix and add node id for emac clock Caesar Wang
2016-01-28  8:43 ` [PATCH v4 4/9] ARM: dts: rockchip: add support emac for RK3036 Caesar Wang
2016-01-28  8:43 ` [PATCH v4 5/9] ARM: dts: rockchip: add mclk for rt5616 on kylin board Caesar Wang
2016-01-28  8:43 ` [PATCH v4 6/9] ASoC: rt5616: add mclk property for rt5616 document Caesar Wang
2016-01-29 16:28   ` Rob Herring
2016-01-31  9:09     ` Caesar Wang [this message]
2016-01-28  8:43 ` [PATCH v4 7/9] ASoC: rt5616: trivial: fix the typo Caesar Wang
2016-01-28  8:43 ` [PATCH v4 8/9] ASoC: rt5616: add the mclk for the codec driver Caesar Wang
2016-01-28  8:43 ` [PATCH v4 9/9] ARM: dts: rockchip: support the spi for rk3036 Caesar Wang
2016-01-31 11:06   ` Heiko Stuebner
2016-02-01  6:32     ` Caesar Wang
2016-01-31  9:10 ` [PATCH v4.1 6/9] ASoC: rt5616: add mclk property for rt5616 document Caesar Wang
2016-02-01 14:48   ` Rob Herring
2016-02-01  7:30 ` [PATCH v4.1 9/9] ARM: dts: rockchip: support the spi for rk3036 Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56ADCF5F.1010203@gmail.com \
    --to=caesar.upstream@gmail.com \
    --cc=broonie@kernel.org \
    --cc=cf@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=hl@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jay.xu@rock-chips.com \
    --cc=jeffy.chen@rock-chips.com \
    --cc=keescook@google.com \
    --cc=leozwang@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=sonnyrao@chromium.org \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).