From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: rtc-linux@googlegroups.com,
Javier Martinez Canillas <javier@osg.samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: k.kozlowski.k@gmail.com, linux-kernel@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>,
Andi Shyti <andi.shyti@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-samsung-soc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support
Date: Sun, 31 Jan 2016 21:11:00 +0900 [thread overview]
Message-ID: <56ADF9D4.2050208@samsung.com> (raw)
In-Reply-To: <20160131120525.GM20165@piout.net>
W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze:
> Hi,
>
> On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote :
>> Hello,
>>
>> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
>> we came to the conclusion that the max77686 and max77802 RTC are almost
>> the same with only a few differences so there shouldn't be two separate
>> drivers and is better to extend max77686 driver and delete rtc-max77802.
>>
>> By making the driver more generic, other RTC IP blocks from Maxim PMICs
>> could be supported as well like the max77620.
>>
>> This is a v4 of a series that do this, that address issues pointed out
>> in the latest version. The v1, v2 and v3 can be found at [1], [2], [3].
>>
>> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
>> a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski
>> tested v3 on an max77686 but this version only has cosmetic changes so
>> it should not cause any functionality changes.
>>
>> [0]: http://www.spinics.net/lists/devicetree/msg110348.html
>> [1]: https://lwn.net/Articles/672568/
>> [2]: https://lkml.org/lkml/2016/1/25/767
>> [3]: https://lkml.org/lkml/2016/1/26/787
>>
>
> I've applied patches 1 to 8 and I'll discussed with Arnd and Olof about
> what I should do with the defconfig changes.
To avoid conflicts they could go through samsung-soc tree. I could pick
them if you provide me a tag with rest of patchset (dependencies).
Would that be okay for you?
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-01-31 12:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 3:36 [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas
2016-01-27 5:57 ` Laxman Dewangan
2016-01-27 3:36 ` [PATCH v4 03/10] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 05/10] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas
2016-01-27 4:23 ` Krzysztof Kozlowski
2016-01-27 4:37 ` Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 07/10] rtc: max77686: Fix unsupported year message Javier Martinez Canillas
2016-01-27 4:24 ` Krzysztof Kozlowski
2016-01-27 3:36 ` [PATCH v4 08/10] rtc: Remove Maxim 77802 driver Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 09/10] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas
2016-01-27 3:36 ` [PATCH v4 10/10] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2016-01-28 1:14 ` [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support Andi Shyti
2016-01-31 12:05 ` Alexandre Belloni
2016-01-31 12:11 ` Krzysztof Kozlowski [this message]
2016-02-04 22:56 ` [rtc-linux] " Alexandre Belloni
2016-02-05 0:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ADF9D4.2050208@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andi.shyti@samsung.com \
--cc=arnd@arndb.de \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski.k@gmail.com \
--cc=kgene@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).