From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933314AbcBAAkj (ORCPT ); Sun, 31 Jan 2016 19:40:39 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:9845 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932824AbcBAAkh (ORCPT ); Sun, 31 Jan 2016 19:40:37 -0500 X-AuditID: cbfec7f4-f79026d00000418a-d0-56aea982bc7d Subject: Re: [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 To: Arnd Bergmann , linux-samsung-soc@vger.kernel.org References: <1454079040-3567945-1-git-send-email-arnd@arndb.de> <1454079040-3567945-2-git-send-email-arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, Kukjin Kim , linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56AEA97F.80206@samsung.com> Date: Mon, 01 Feb 2016 09:40:31 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1454079040-3567945-2-git-send-email-arnd@arndb.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xa7pNK9eFGZxslLb4O+kYu8XrF4YW /Y9fM1tsenyN1eLyrjlsFjPO72NyYPP4/WsSo8emVZ1sHpuX1Hv0bVnF6PF5k1wAaxSXTUpq TmZZapG+XQJXxqqHPawF59grFu6bxtTAOI+ti5GTQ0LAROLZ26NMELaYxIV764HiXBxCAksZ JZqaT7JCOE8ZJbbPuMAMUiUsYC+xq3cVC4gtIuAisb7jIFhcSKBU4tWT/2BxZoF0icWLzoJN ZRMwlti8fAnYNl4BDYmtJ+aA1bMIqErs+n8UrF5UIELicGcXO0SNoMSPyffA4pwCDhLtx9cD zeEAmqkncf+iFsR4eYnNa94yT2AUmIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al 6yXn525ihAT1lx2Mi49ZHWIU4GBU4uHdELkuTIg1say4MvcQowQHs5II71MToBBvSmJlVWpR fnxRaU5q8SFGaQ4WJXHeubvehwgJpCeWpGanphakFsFkmTg4pRoYjW1LN5fWn7yaU3Gk03jb fXWny/tWNMyUCNh6tGNDuNOVGQd05d/w/8thr3uwoN5c50zqZ+1TbHtsWMQneBb/dd35KdH9 6SFFzieZ250les90TtghkFPP5MXcODeswN6B0yjyAPOzB8vmrmKasqyW406hWwf7Z44L85dP P/nm+O57m1dsSJ27WomlOCPRUIu5qDgRAB/JR85mAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.01.2016 23:50, Arnd Bergmann wrote: > EEPROM_AT24 depends on both I2C and SYSFS. We have in the past > added I2C 'select' statements to avoid build problems with the > first, but we still get a warning because of the second: > > warning: (MACH_DAVINCI_EVM && MACH_SFFSDR && MACH_DAVINCI_DM6467_EVM && MACH_DAVINCI_DM365_EVM && MACH_DAVINCI_DA830_EVM && MACH_MITYOMAPL138 && MACH_MINI2440) selects EEPROM_AT24 which has unmet direct dependencies (I2C && SYSFS) > > This removes the 'select' statements again, and forces users to > enable the driver in their configuration files, as we do for > most other drivers. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/configs/mini2440_defconfig | 1 + > arch/arm/configs/s3c2410_defconfig | 1 + > arch/arm/mach-s3c24xx/Kconfig | 1 - > 3 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof