* [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 [not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de> @ 2016-01-29 14:50 ` Arnd Bergmann 2016-02-01 0:40 ` Krzysztof Kozlowski 2016-01-29 14:50 ` [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 Arnd Bergmann ` (4 subsequent siblings) 5 siblings, 1 reply; 12+ messages in thread From: Arnd Bergmann @ 2016-01-29 14:50 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, Arnd Bergmann, Kukjin Kim, Krzysztof Kozlowski, linux-kernel EEPROM_AT24 depends on both I2C and SYSFS. We have in the past added I2C 'select' statements to avoid build problems with the first, but we still get a warning because of the second: warning: (MACH_DAVINCI_EVM && MACH_SFFSDR && MACH_DAVINCI_DM6467_EVM && MACH_DAVINCI_DM365_EVM && MACH_DAVINCI_DA830_EVM && MACH_MITYOMAPL138 && MACH_MINI2440) selects EEPROM_AT24 which has unmet direct dependencies (I2C && SYSFS) This removes the 'select' statements again, and forces users to enable the driver in their configuration files, as we do for most other drivers. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/configs/mini2440_defconfig | 1 + arch/arm/configs/s3c2410_defconfig | 1 + arch/arm/mach-s3c24xx/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/mini2440_defconfig b/arch/arm/configs/mini2440_defconfig index 9c93f5655248..0b02e4f43c6a 100644 --- a/arch/arm/configs/mini2440_defconfig +++ b/arch/arm/configs/mini2440_defconfig @@ -158,6 +158,7 @@ CONFIG_I2C=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_S3C2410=y CONFIG_I2C_SIMTEC=y +CONFIG_EEPROM_AT24=y CONFIG_SPI=y CONFIG_SPI_S3C24XX=y CONFIG_SPI_SPIDEV=y diff --git a/arch/arm/configs/s3c2410_defconfig b/arch/arm/configs/s3c2410_defconfig index f3142369f594..b3ade552a2a5 100644 --- a/arch/arm/configs/s3c2410_defconfig +++ b/arch/arm/configs/s3c2410_defconfig @@ -290,6 +290,7 @@ CONFIG_HW_RANDOM=y CONFIG_I2C_CHARDEV=m CONFIG_I2C_S3C2410=y CONFIG_I2C_SIMTEC=y +CONFIG_EEPROM_AT24=y CONFIG_SPI=y CONFIG_SPI_GPIO=m CONFIG_SPI_S3C24XX=m diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index ef68ecb27396..c94ef77405ed 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -460,7 +460,6 @@ config MACH_AT2440EVB config MACH_MINI2440 bool "MINI2440 development board" - select EEPROM_AT24 if I2C select LEDS_CLASS select LEDS_TRIGGERS select LEDS_TRIGGER_BACKLIGHT -- 2.7.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 2016-01-29 14:50 ` [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 Arnd Bergmann @ 2016-02-01 0:40 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2016-02-01 0:40 UTC (permalink / raw) To: Arnd Bergmann, linux-samsung-soc Cc: linux-arm-kernel, Kukjin Kim, linux-kernel On 29.01.2016 23:50, Arnd Bergmann wrote: > EEPROM_AT24 depends on both I2C and SYSFS. We have in the past > added I2C 'select' statements to avoid build problems with the > first, but we still get a warning because of the second: > > warning: (MACH_DAVINCI_EVM && MACH_SFFSDR && MACH_DAVINCI_DM6467_EVM && MACH_DAVINCI_DM365_EVM && MACH_DAVINCI_DA830_EVM && MACH_MITYOMAPL138 && MACH_MINI2440) selects EEPROM_AT24 which has unmet direct dependencies (I2C && SYSFS) > > This removes the 'select' statements again, and forces users to > enable the driver in their configuration files, as we do for > most other drivers. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/configs/mini2440_defconfig | 1 + > arch/arm/configs/s3c2410_defconfig | 1 + > arch/arm/mach-s3c24xx/Kconfig | 1 - > 3 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 [not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de> 2016-01-29 14:50 ` [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 Arnd Bergmann @ 2016-01-29 14:50 ` Arnd Bergmann 2016-02-01 0:46 ` Krzysztof Kozlowski 2016-01-29 14:50 ` [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Arnd Bergmann ` (3 subsequent siblings) 5 siblings, 1 reply; 12+ messages in thread From: Arnd Bergmann @ 2016-01-29 14:50 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, Arnd Bergmann, Kukjin Kim, Krzysztof Kozlowski, linux-kernel The S3C2440_XTAL_16934400 and S3C2440_XTAL_12000000 symbols are used for both s3c2442 and s3c2440, but Kconfig only allows it to be selected if CPU_S3C2440 is enabled, which can lead to a warning otherwise: warning: (MACH_RX1950) selects S3C2440_XTAL_16934400 which has unmet direct dependencies (ARCH_S3C24XX && CPU_S3C2440) This changes the dependencies to make it possible also for CPU_S3C2442-only configurations. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-s3c24xx/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index c94ef77405ed..5884bbb7952e 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -405,7 +405,7 @@ config MACH_S3C2416_DT endif # CPU_S3C2416 -if CPU_S3C2440 +if CPU_S3C2440 || CPU_S3C2442 config S3C2440_XTAL_12000000 bool @@ -432,6 +432,9 @@ config S3C2440_PLL_16934400 default y if S3C24XX_PLL help PLL tables for S3C2440 or S3C2442 CPUs with 16.934MHz crystals. +endif + +if CPU_S3C2440 comment "S3C2440 Boards" -- 2.7.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 2016-01-29 14:50 ` [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 Arnd Bergmann @ 2016-02-01 0:46 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2016-02-01 0:46 UTC (permalink / raw) To: Arnd Bergmann, linux-samsung-soc Cc: linux-arm-kernel, Kukjin Kim, linux-kernel On 29.01.2016 23:50, Arnd Bergmann wrote: > The S3C2440_XTAL_16934400 and S3C2440_XTAL_12000000 symbols are used > for both s3c2442 and s3c2440, but Kconfig only allows it to be selected > if CPU_S3C2440 is enabled, which can lead to a warning otherwise: > > warning: (MACH_RX1950) selects S3C2440_XTAL_16934400 which has unmet direct dependencies (ARCH_S3C24XX && CPU_S3C2440) > > This changes the dependencies to make it possible also for CPU_S3C2442-only > configurations. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c24xx/Kconfig | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning [not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de> 2016-01-29 14:50 ` [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 Arnd Bergmann 2016-01-29 14:50 ` [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 Arnd Bergmann @ 2016-01-29 14:50 ` Arnd Bergmann 2016-02-01 0:49 ` Krzysztof Kozlowski 2016-01-29 14:50 ` [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann ` (2 subsequent siblings) 5 siblings, 1 reply; 12+ messages in thread From: Arnd Bergmann @ 2016-01-29 14:50 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, Arnd Bergmann, Kukjin Kim, Krzysztof Kozlowski, linux-kernel gta02_configure_pmu_for_charger is only used when CONFIG_PCF50633_ADC is set, and otherwise we get a warning about an unused symbol: arch/arm/mach-s3c24xx/mach-gta02.c:158:1: warning: 'gta02_configure_pmu_for_charger' defined but not used [-Wunused-function] gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res) This adds an #ifdef to shut up the warning. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-s3c24xx/mach-gta02.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c index 6d1e0b9c5b27..27ae6877550f 100644 --- a/arch/arm/mach-s3c24xx/mach-gta02.c +++ b/arch/arm/mach-s3c24xx/mach-gta02.c @@ -154,6 +154,7 @@ static struct s3c2410_uartcfg gta02_uartcfgs[] = { #define ADC_NOM_CHG_DETECT_1A 6 #define ADC_NOM_CHG_DETECT_USB 43 +#ifdef CONFIG_PCF50633_ADC static void gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res) { @@ -174,6 +175,7 @@ gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res) pcf50633_mbc_usb_curlim_set(pcf, ma); } +#endif static struct delayed_work gta02_charger_work; static int gta02_usb_vbus_draw; -- 2.7.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning 2016-01-29 14:50 ` [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Arnd Bergmann @ 2016-02-01 0:49 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2016-02-01 0:49 UTC (permalink / raw) To: Arnd Bergmann, linux-samsung-soc Cc: linux-arm-kernel, Kukjin Kim, linux-kernel On 29.01.2016 23:50, Arnd Bergmann wrote: > gta02_configure_pmu_for_charger is only used when CONFIG_PCF50633_ADC > is set, and otherwise we get a warning about an unused symbol: > > arch/arm/mach-s3c24xx/mach-gta02.c:158:1: warning: 'gta02_configure_pmu_for_charger' defined but not used [-Wunused-function] > gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res) > > This adds an #ifdef to shut up the warning. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c24xx/mach-gta02.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled [not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de> ` (2 preceding siblings ...) 2016-01-29 14:50 ` [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Arnd Bergmann @ 2016-01-29 14:50 ` Arnd Bergmann 2016-02-01 0:59 ` Krzysztof Kozlowski 2016-01-29 14:50 ` [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused Arnd Bergmann 2016-01-29 14:50 ` [PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann 5 siblings, 1 reply; 12+ messages in thread From: Arnd Bergmann @ 2016-01-29 14:50 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, Arnd Bergmann, Kukjin Kim, Krzysztof Kozlowski, linux-kernel Bluetooth is only supported when network support is part of the kernel, so it is a bit pointless to build the hi1940-bt support without networking. If we try anyway, we get a Kconfig warning: warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) This adds a dependency on CONFIG_NET to avoid that case. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-s3c24xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index 5884bbb7952e..bf66c8334822 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -227,7 +227,7 @@ config ARCH_H1940 config H1940BT tristate "Control the state of H1940 bluetooth chip" - depends on ARCH_H1940 + depends on ARCH_H1940 && NET select RFKILL help This is a simple driver that is able to control -- 2.7.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled 2016-01-29 14:50 ` [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann @ 2016-02-01 0:59 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2016-02-01 0:59 UTC (permalink / raw) To: Arnd Bergmann, linux-samsung-soc Cc: linux-arm-kernel, Kukjin Kim, linux-kernel On 29.01.2016 23:50, Arnd Bergmann wrote: > Bluetooth is only supported when network support is part of the kernel, > so it is a bit pointless to build the hi1940-bt support without networking. > If we try anyway, we get a Kconfig warning: > > warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) > > This adds a dependency on CONFIG_NET to avoid that case. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c24xx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig > index 5884bbb7952e..bf66c8334822 100644 > --- a/arch/arm/mach-s3c24xx/Kconfig > +++ b/arch/arm/mach-s3c24xx/Kconfig > @@ -227,7 +227,7 @@ config ARCH_H1940 > > config H1940BT > tristate "Control the state of H1940 bluetooth chip" > - depends on ARCH_H1940 > + depends on ARCH_H1940 && NET > select RFKILL > help > This is a simple driver that is able to control I think there shouldn't be a reverse dependency for RFKILL but instead just: depends on ARCH_H1940 && RFKILL This makes it simpler and RFKILL is a user-visible symbol. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused [not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de> ` (3 preceding siblings ...) 2016-01-29 14:50 ` [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann @ 2016-01-29 14:50 ` Arnd Bergmann 2016-02-01 1:18 ` Krzysztof Kozlowski 2016-01-29 14:50 ` [PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann 5 siblings, 1 reply; 12+ messages in thread From: Arnd Bergmann @ 2016-01-29 14:50 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, Arnd Bergmann, Kukjin Kim, Krzysztof Kozlowski, linux-kernel The smdk6410 board defines lots of regulator settings, but uses most of them only in certain configurations, and otherwise leaves them without any references, so we get lots of randconfig warnings about them: mach-s3c64xx/mach-smdk6410.c:303:35: error: 'smdk6410_vddarm' defined but not used [-Werror=unused-variable] mach-s3c64xx/mach-smdk6410.c:316:35: error: 'smdk6410_vddint' defined but not used [-Werror=unused-variable] mach-s3c64xx/mach-smdk6410.c:327:35: error: 'smdk6410_vddhi' defined but not used [-Werror=unused-variable] mach-s3c64xx/mach-smdk6410.c:335:35: error: 'smdk6410_vddpll' defined but not used [-Werror=unused-variable] mach-s3c64xx/mach-smdk6410.c:343:35: error: 'smdk6410_vdduh_mmc' defined but not used [-Werror=unused-variable] This marks all regulator_init_data structures in this file as __maybe_unused, indicating that we don't care whether there are any references or not in a given configuration. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-s3c64xx/mach-smdk6410.c | 38 +++++++++++++++++------------------ 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-s3c64xx/mach-smdk6410.c index 8a894ee3ee76..92ec8c3b42b9 100644 --- a/arch/arm/mach-s3c64xx/mach-smdk6410.c +++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c @@ -216,7 +216,7 @@ static struct regulator_consumer_supply smdk6410_b_pwr_5v_consumers[] = { REGULATOR_SUPPLY("AVDD", "0-001b"), }; -static struct regulator_init_data smdk6410_b_pwr_5v_data = { +static struct regulator_init_data __maybe_unused smdk6410_b_pwr_5v_data = { .constraints = { .always_on = 1, }, @@ -300,7 +300,7 @@ static struct regulator_consumer_supply smdk6410_vddarm_consumers[] = { }; /* VDDARM, BUCK1 on J5 */ -static struct regulator_init_data smdk6410_vddarm = { +static struct regulator_init_data __maybe_unused smdk6410_vddarm = { .constraints = { .name = "PVDD_ARM", .min_uV = 1000000, @@ -313,7 +313,7 @@ static struct regulator_init_data smdk6410_vddarm = { }; /* VDD_INT, BUCK2 on J5 */ -static struct regulator_init_data smdk6410_vddint = { +static struct regulator_init_data __maybe_unused smdk6410_vddint = { .constraints = { .name = "PVDD_INT", .min_uV = 1000000, @@ -324,7 +324,7 @@ static struct regulator_init_data smdk6410_vddint = { }; /* VDD_HI, LDO3 on J5 */ -static struct regulator_init_data smdk6410_vddhi = { +static struct regulator_init_data __maybe_unused smdk6410_vddhi = { .constraints = { .name = "PVDD_HI", .always_on = 1, @@ -332,7 +332,7 @@ static struct regulator_init_data smdk6410_vddhi = { }; /* VDD_PLL, LDO2 on J5 */ -static struct regulator_init_data smdk6410_vddpll = { +static struct regulator_init_data __maybe_unused smdk6410_vddpll = { .constraints = { .name = "PVDD_PLL", .always_on = 1, @@ -340,7 +340,7 @@ static struct regulator_init_data smdk6410_vddpll = { }; /* VDD_UH_MMC, LDO5 on J5 */ -static struct regulator_init_data smdk6410_vdduh_mmc = { +static struct regulator_init_data __maybe_unused smdk6410_vdduh_mmc = { .constraints = { .name = "PVDD_UH+PVDD_MMC", .always_on = 1, @@ -348,7 +348,7 @@ static struct regulator_init_data smdk6410_vdduh_mmc = { }; /* VCCM3BT, LDO8 on J5 */ -static struct regulator_init_data smdk6410_vccmc3bt = { +static struct regulator_init_data __maybe_unused smdk6410_vccmc3bt = { .constraints = { .name = "PVCCM3BT", .always_on = 1, @@ -356,7 +356,7 @@ static struct regulator_init_data smdk6410_vccmc3bt = { }; /* VCCM2MTV, LDO11 on J5 */ -static struct regulator_init_data smdk6410_vccm2mtv = { +static struct regulator_init_data __maybe_unused smdk6410_vccm2mtv = { .constraints = { .name = "PVCCM2MTV", .always_on = 1, @@ -364,7 +364,7 @@ static struct regulator_init_data smdk6410_vccm2mtv = { }; /* VDD_LCD, LDO12 on J5 */ -static struct regulator_init_data smdk6410_vddlcd = { +static struct regulator_init_data __maybe_unused smdk6410_vddlcd = { .constraints = { .name = "PVDD_LCD", .always_on = 1, @@ -372,7 +372,7 @@ static struct regulator_init_data smdk6410_vddlcd = { }; /* VDD_OTGI, LDO9 on J5 */ -static struct regulator_init_data smdk6410_vddotgi = { +static struct regulator_init_data __maybe_unused smdk6410_vddotgi = { .constraints = { .name = "PVDD_OTGI", .always_on = 1, @@ -380,7 +380,7 @@ static struct regulator_init_data smdk6410_vddotgi = { }; /* VDD_OTG, LDO14 on J5 */ -static struct regulator_init_data smdk6410_vddotg = { +static struct regulator_init_data __maybe_unused smdk6410_vddotg = { .constraints = { .name = "PVDD_OTG", .always_on = 1, @@ -388,7 +388,7 @@ static struct regulator_init_data smdk6410_vddotg = { }; /* VDD_ALIVE, LDO15 on J5 */ -static struct regulator_init_data smdk6410_vddalive = { +static struct regulator_init_data __maybe_unused smdk6410_vddalive = { .constraints = { .name = "PVDD_ALIVE", .always_on = 1, @@ -396,7 +396,7 @@ static struct regulator_init_data smdk6410_vddalive = { }; /* VDD_AUDIO, VLDO_AUDIO on J5 */ -static struct regulator_init_data smdk6410_vddaudio = { +static struct regulator_init_data __maybe_unused smdk6410_vddaudio = { .constraints = { .name = "PVDD_AUDIO", .always_on = 1, @@ -406,7 +406,7 @@ static struct regulator_init_data smdk6410_vddaudio = { #ifdef CONFIG_SMDK6410_WM1190_EV1 /* S3C64xx internal logic & PLL */ -static struct regulator_init_data wm8350_dcdc1_data = { +static struct regulator_init_data __maybe_unused wm8350_dcdc1_data = { .constraints = { .name = "PVDD_INT+PVDD_PLL", .min_uV = 1200000, @@ -417,7 +417,7 @@ static struct regulator_init_data wm8350_dcdc1_data = { }; /* Memory */ -static struct regulator_init_data wm8350_dcdc3_data = { +static struct regulator_init_data __maybe_unused wm8350_dcdc3_data = { .constraints = { .name = "PVDD_MEM", .min_uV = 1800000, @@ -437,7 +437,7 @@ static struct regulator_consumer_supply wm8350_dcdc4_consumers[] = { REGULATOR_SUPPLY("DVDD", "0-001b"), }; -static struct regulator_init_data wm8350_dcdc4_data = { +static struct regulator_init_data __maybe_unused wm8350_dcdc4_data = { .constraints = { .name = "PVDD_HI+PVDD_EXT+PVDD_SYS+PVCCM2MTV", .min_uV = 3000000, @@ -449,7 +449,7 @@ static struct regulator_init_data wm8350_dcdc4_data = { }; /* OTGi/1190-EV1 HPVDD & AVDD */ -static struct regulator_init_data wm8350_ldo4_data = { +static struct regulator_init_data __maybe_unused wm8350_ldo4_data = { .constraints = { .name = "PVDD_OTGI+HPVDD+AVDD", .min_uV = 1200000, @@ -537,7 +537,7 @@ static struct wm831x_backlight_pdata wm1192_backlight_pdata = { .max_uA = 27554, }; -static struct regulator_init_data wm1192_dcdc3 = { +static struct regulator_init_data __maybe_unused wm1192_dcdc3 = { .constraints = { .name = "PVDD_MEM+PVDD_GPS", .always_on = 1, @@ -548,7 +548,7 @@ static struct regulator_consumer_supply wm1192_ldo1_consumers[] = { REGULATOR_SUPPLY("DVDD", "0-001b"), /* WM8580 */ }; -static struct regulator_init_data wm1192_ldo1 = { +static struct regulator_init_data __maybe_unused wm1192_ldo1 = { .constraints = { .name = "PVDD_LCD+PVDD_EXT", .always_on = 1, -- 2.7.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused 2016-01-29 14:50 ` [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused Arnd Bergmann @ 2016-02-01 1:18 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2016-02-01 1:18 UTC (permalink / raw) To: Arnd Bergmann, linux-samsung-soc Cc: linux-arm-kernel, Kukjin Kim, linux-kernel On 29.01.2016 23:50, Arnd Bergmann wrote: > The smdk6410 board defines lots of regulator settings, but uses > most of them only in certain configurations, and otherwise leaves > them without any references, so we get lots of randconfig warnings > about them: > > mach-s3c64xx/mach-smdk6410.c:303:35: error: 'smdk6410_vddarm' defined but not used [-Werror=unused-variable] > mach-s3c64xx/mach-smdk6410.c:316:35: error: 'smdk6410_vddint' defined but not used [-Werror=unused-variable] > mach-s3c64xx/mach-smdk6410.c:327:35: error: 'smdk6410_vddhi' defined but not used [-Werror=unused-variable] > mach-s3c64xx/mach-smdk6410.c:335:35: error: 'smdk6410_vddpll' defined but not used [-Werror=unused-variable] > mach-s3c64xx/mach-smdk6410.c:343:35: error: 'smdk6410_vdduh_mmc' defined but not used [-Werror=unused-variable] > > This marks all regulator_init_data structures in this file as > __maybe_unused, indicating that we don't care whether there > are any references or not in a given configuration. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c64xx/mach-smdk6410.c | 38 +++++++++++++++++------------------ > 1 file changed, 19 insertions(+), 19 deletions(-) > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 6/6] ARM: exynos: select THERMAL_OF [not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de> ` (4 preceding siblings ...) 2016-01-29 14:50 ` [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused Arnd Bergmann @ 2016-01-29 14:50 ` Arnd Bergmann 2016-02-01 1:26 ` Krzysztof Kozlowski 5 siblings, 1 reply; 12+ messages in thread From: Arnd Bergmann @ 2016-01-29 14:50 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, Arnd Bergmann, Kukjin Kim, Krzysztof Kozlowski, linux-kernel We cannot select a symbol that has disabled dependencies, so we get a warning if we ever enable EXYNOS_THERMAL without also turning on THERMAL_OF: warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF) This adds another 'select' in the platform code to avoid that case. Alternatively, we could decide to not select EXYNOS_THERMAL here and instead make it a user option. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-exynos/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 652a0bb11578..5189bcecad12 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS select S5P_DEV_MFC select SRAM select THERMAL + select THERMAL_OF select MFD_SYSCON select CLKSRC_EXYNOS_MCT select POWER_RESET -- 2.7.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 6/6] ARM: exynos: select THERMAL_OF 2016-01-29 14:50 ` [PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann @ 2016-02-01 1:26 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2016-02-01 1:26 UTC (permalink / raw) To: Arnd Bergmann, linux-samsung-soc Cc: linux-arm-kernel, Kukjin Kim, linux-kernel On 29.01.2016 23:50, Arnd Bergmann wrote: > We cannot select a symbol that has disabled dependencies, so > we get a warning if we ever enable EXYNOS_THERMAL without > also turning on THERMAL_OF: > > warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF) > > This adds another 'select' in the platform code to avoid that > case. Alternatively, we could decide to not select EXYNOS_THERMAL > here and instead make it a user option. We want EXYNOS_THERMAL because we are using boost cpufreq on Exynos4x12 (through turbo frequencies in DTS and cpufreq-dt) so your current solution is a proper fix for: Fixes: f87e6bd3f740 ("thermal: exynos: Add the dependency of CONFIG_THERMAL_OF instead of CONFIG_OF") Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-exynos/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 652a0bb11578..5189bcecad12 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select S5P_DEV_MFC > select SRAM > select THERMAL > + select THERMAL_OF > select MFD_SYSCON > select CLKSRC_EXYNOS_MCT > select POWER_RESET > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-02-01 1:26 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1454079040-3567945-1-git-send-email-arnd@arndb.de>
2016-01-29 14:50 ` [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 Arnd Bergmann
2016-02-01 0:40 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 2/6] ARM: s3c24xx: allow selecting S3C2440_XTAL_16934400 for s3c2442 Arnd Bergmann
2016-02-01 0:46 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Arnd Bergmann
2016-02-01 0:49 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann
2016-02-01 0:59 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 5/6] ARM: s3c64xx: mark regulator init data as unused Arnd Bergmann
2016-02-01 1:18 ` Krzysztof Kozlowski
2016-01-29 14:50 ` [PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann
2016-02-01 1:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).