From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933375AbcBAA74 (ORCPT ); Sun, 31 Jan 2016 19:59:56 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:9910 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932824AbcBAA7z (ORCPT ); Sun, 31 Jan 2016 19:59:55 -0500 X-AuditID: cbfec7f4-f79026d00000418a-8d-56aeae081c58 Subject: Re: [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled To: Arnd Bergmann , linux-samsung-soc@vger.kernel.org References: <1454079040-3567945-1-git-send-email-arnd@arndb.de> <1454079040-3567945-5-git-send-email-arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, Kukjin Kim , linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56AEAE04.6030601@samsung.com> Date: Mon, 01 Feb 2016 09:59:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1454079040-3567945-5-git-send-email-arnd@arndb.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xK7oc69aFGVz7x2Lxd9IxdovXLwwt +h+/ZrbY9Pgaq8XlXXPYLGac38fkwObx+9ckRo9NqzrZPDYvqffo27KK0ePzJrkA1igum5TU nMyy1CJ9uwSujK7LT9gKTnJWNG4/yNrAeIO9i5GTQ0LAROJC718WCFtM4sK99WxdjFwcQgJL GSVWHL0P5TxllPh1cjcrSJWwQJjEg9YvzCC2iICLxPqOg2C2kECpxNd1X9hAbGaBdInFi84y gdhsAsYSm5cvAYvzCmhJHNn+gBHEZhFQlTjRtwxss6hAhMThzi52iBpBiR+T74HFOQUcJPau WQIU5wCaqSdx/6IWxHh5ic1r3jJPYBSYhaRjFkLVLCRVCxiZVzGKppYmFxQnpeca6hUn5haX 5qXrJefnbmKEBPWXHYyLj1kdYhTgYFTi4d0QuS5MiDWxrLgy9xCjBAezkgjvUxOgEG9KYmVV alF+fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhgXTS0x2Ld5/m/HJOaE 6k/mYpKn+T9eCdpYKL7TVeO1cmynsq/gBRZP7n26N+5wfb9yw75/spiU8SPGpCuznIK0TCLj NbUvbzVff77xeQCrU1TVp67mezH8904+W2rptSA16sB/Fv8fvvkX7LKa/ZetsLm1Z/vRxAe/ FCR8Z9+yO385pDooWEiJpTgj0VCLuag4EQDapDVlZgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.01.2016 23:50, Arnd Bergmann wrote: > Bluetooth is only supported when network support is part of the kernel, > so it is a bit pointless to build the hi1940-bt support without networking. > If we try anyway, we get a Kconfig warning: > > warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) > > This adds a dependency on CONFIG_NET to avoid that case. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-s3c24xx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig > index 5884bbb7952e..bf66c8334822 100644 > --- a/arch/arm/mach-s3c24xx/Kconfig > +++ b/arch/arm/mach-s3c24xx/Kconfig > @@ -227,7 +227,7 @@ config ARCH_H1940 > > config H1940BT > tristate "Control the state of H1940 bluetooth chip" > - depends on ARCH_H1940 > + depends on ARCH_H1940 && NET > select RFKILL > help > This is a simple driver that is able to control I think there shouldn't be a reverse dependency for RFKILL but instead just: depends on ARCH_H1940 && RFKILL This makes it simpler and RFKILL is a user-visible symbol. Best regards, Krzysztof