From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933468AbcBAB0k (ORCPT ); Sun, 31 Jan 2016 20:26:40 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:37774 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933224AbcBAB0i (ORCPT ); Sun, 31 Jan 2016 20:26:38 -0500 X-AuditID: cbfec7f4-f79026d00000418a-16-56aeb44b8298 Subject: Re: [PATCH 6/6] ARM: exynos: select THERMAL_OF To: Arnd Bergmann , linux-samsung-soc@vger.kernel.org References: <1454079040-3567945-1-git-send-email-arnd@arndb.de> <1454079040-3567945-7-git-send-email-arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, Kukjin Kim , linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56AEB448.1080108@samsung.com> Date: Mon, 01 Feb 2016 10:26:32 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1454079040-3567945-7-git-send-email-arnd@arndb.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xy7reW9aFGRzZLmvxd9IxdovXLwwt +h+/ZrbY9Pgaq8XlXXPYLGac38fkwObx+9ckRo9NqzrZPDYvqffo27KK0ePzJrkA1igum5TU nMyy1CJ9uwSujBl3nAoWcVdsPPSYuYFxFmcXIyeHhICJxMumm2wQtpjEhXvrgWwuDiGBpYwS 2+8fZYJwnjJKTP6zhhGkSljAXOLs3hlgtoiAi8T6joPMXYwcQEWlEqcvmYOEmQXSJRYvOssE YrMJGEtsXr4EbAGvgJbE8StbwOIsAqoSU5o2M4PYogIREoc7u9ghagQlfky+xwJicwo4SJx5 08wKMp5ZQE/i/kUtiPHyEpvXvGWewCgwC0nHLISqWUiqFjAyr2IUTS1NLihOSs811CtOzC0u zUvXS87P3cQICegvOxgXH7M6xCjAwajEw7shcl2YEGtiWXFl7iFGCQ5mJRHepyZAId6UxMqq 1KL8+KLSnNTiQ4zSHCxK4rxzd70PERJITyxJzU5NLUgtgskycXBKNTDyvpi4/uvb6XoH3P6n THJZtPBHx8GAySVCS/eo8B/vq1NJf5G+dM5xph1PeP9ujLMWnuflMuHO4dm3k60DZfYqO1Tm pT+44bQr93fo6WrBj41fv3LanA4OKPl11HhRthCH4Zy8ZSu+hpyceUH673Jer9B7rZn+dgyH mvaqvS6oy97ffOZtbby9EktxRqKhFnNRcSIAwz2gw2QCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.01.2016 23:50, Arnd Bergmann wrote: > We cannot select a symbol that has disabled dependencies, so > we get a warning if we ever enable EXYNOS_THERMAL without > also turning on THERMAL_OF: > > warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF) > > This adds another 'select' in the platform code to avoid that > case. Alternatively, we could decide to not select EXYNOS_THERMAL > here and instead make it a user option. We want EXYNOS_THERMAL because we are using boost cpufreq on Exynos4x12 (through turbo frequencies in DTS and cpufreq-dt) so your current solution is a proper fix for: Fixes: f87e6bd3f740 ("thermal: exynos: Add the dependency of CONFIG_THERMAL_OF instead of CONFIG_OF") Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-exynos/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 652a0bb11578..5189bcecad12 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select S5P_DEV_MFC > select SRAM > select THERMAL > + select THERMAL_OF > select MFD_SYSCON > select CLKSRC_EXYNOS_MCT > select POWER_RESET >