From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757556AbcBACfd (ORCPT ); Sun, 31 Jan 2016 21:35:33 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:37002 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbcBACfb (ORCPT ); Sun, 31 Jan 2016 21:35:31 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wdc@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: wdc@rock-chips.com X-UNIQUE-TAG: <45b55b34040d9f6bf07e2303b5a0e4d9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 2/2] dt-bindings: rockchip-pinctrl: Support the RK3399 SoCs compatible To: Heiko Stuebner , David Wu References: <1451997055-47655-1-git-send-email-wdc@rock-chips.com> <1454153517-52969-1-git-send-email-david.wu@rock-chips.com> <1454153517-52969-3-git-send-email-david.wu@rock-chips.com> <14543443.RsRWh5K5Uv@phil> Cc: linus.walleij@linaro.org, huangtao@rock-chips.com, zyw@rock-chips.com, cf@rock-chips.com, xjq@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org From: "David.Wu" Message-ID: <56AEC472.9030909@rock-chips.com> Date: Mon, 1 Feb 2016 10:35:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <14543443.RsRWh5K5Uv@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, 在 2016/1/30 20:16, Heiko Stuebner 写道: > Hi David, > > Am Samstag, 30. Januar 2016, 19:31:57 schrieb David Wu: >> Change-Id: Ic1bdb3dc358837e97d7b48dd58be2f8d9d08d766 > please no Change-Id, it's missing the Signed-off, and as Linus Walleij said, > the compatible addition to the documentation can maybe stay in the pinctrl- > patch itself. > > I think both Linus and me overlooked that the binding-doc-addition was > already correctly included in your v2 patch at the top :-) > Okay, I will merge it in one patch. sorry for my misunderstand. > Heiko > >> --- >> Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt >> b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt index >> 391ef4b..3bb9456 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.txt >> @@ -22,6 +22,7 @@ Required properties for iomux controller: >> - compatible: one of "rockchip,rk2928-pinctrl", >> "rockchip,rk3066a-pinctrl" "rockchip,rk3066b-pinctrl", >> "rockchip,rk3188-pinctrl" >> "rockchip,rk3288-pinctrl", "rockchip,rk3368-pinctrl" >> + "rockchip,rk3399-pinctrl" >> - rockchip,grf: phandle referencing a syscon providing the >> "general register files" > > >