From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933698AbcBADdk (ORCPT <rfc822;w@1wt.eu>);
	Sun, 31 Jan 2016 22:33:40 -0500
Received: from mail-pf0-f194.google.com ([209.85.192.194]:33904 "EHLO
	mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933617AbcBADdh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 31 Jan 2016 22:33:37 -0500
Subject: Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512
 UART driver
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linus.walleij@linaro.org, gnurou@gmail.com, gregkh@linuxfoundation.org,
        paul.gortmaker@windriver.com, lee.jones@linaro.org, jslaby@suse.com,
        peter_hong@fintek.com.tw
References: <1453972838-30268-1-git-send-email-hpeter+linux_kernel@gmail.com>
 <1453972838-30268-5-git-send-email-hpeter+linux_kernel@gmail.com>
 <1453982657.2521.287.camel@linux.intel.com> <56AB20B1.9030609@gmail.com>
 <1454071220.2521.311.camel@linux.intel.com>
Cc: heikki.krogerus@linux.intel.com, peter@hurleysoftware.com,
        soeren.grunewald@desy.de, udknight@gmail.com, adam.lee@canonical.com,
        arnd@arndb.de, manabian@gmail.com, scottwood@freescale.com,
        yamada.masahiro@socionext.com, paul.burton@imgtec.com, mans@mansr.com,
        matthias.bgg@gmail.com, ralf@linux-mips.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-serial@vger.kernel.org, tom_tsai@fintek.com.tw,
        Peter Hung <hpeter+linux_kernel@gmail.com>
From: Peter Hung <hpeter@gmail.com>
Message-ID: <56AED212.5010903@gmail.com>
Date: Mon, 1 Feb 2016 11:33:38 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1454071220.2521.311.camel@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

Andy Shevchenko 於 2016/1/29 下午 08:40 寫道:
> On Fri, 2016-01-29 at 16:20 +0800, Peter Hung wrote:
>> Hi Andy,
>>
>> Andy Shevchenko 於 2016/1/28 下午 08:04 寫道:
>>> On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote:
>>>> -	/* Fintek PCI serial cards */
>>>> -	{ PCI_DEVICE(0x1c29, 0x1104), .driver_data =
>>>> pbn_fintek_4 },
>>>> -	{ PCI_DEVICE(0x1c29, 0x1108), .driver_data =
>>>> pbn_fintek_8 },
>>>> -	{ PCI_DEVICE(0x1c29, 0x1112), .driver_data =
>>>> pbn_fintek_12
>>>> },
>>>
>>> Shouldn't you blacklist them in 8250_pci?
>>>
>>
>> You are referring to add blacklist instead of remove F81504/508/512
>> code?
>
> No.
>
>>   or add blacklist and remove code?
>
> This one.

ok

> Check what lspci tells you about your device. I'm pretty sure that it
> has Serial Class, which would trigger enumeration in 8250_pci.c if it
> comes first.
>

I had add log with 8250_pci.c. It really trigger once by 8250_pci.c,
but will failed with serial_pci_guess_board(). So It can be handled by
f81504-core.c. I should add pid/vid to blacklist and comments it'll
be handled by f81504-core.c

Thanks
-- 
With Best Regards,
Peter Hung