From: Ian Abbott <abbotti@mev.co.uk>
To: "Pablo G. Gallardo" <gallardo_pablo@hotmail.com>, greg@kroah.com
Cc: hsweeten@visionengravers.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] STAGING: COMEDI: Remove unnecessary typecast of c90 int constant
Date: Mon, 1 Feb 2016 11:16:44 +0000 [thread overview]
Message-ID: <56AF3E9C.1040000@mev.co.uk> (raw)
In-Reply-To: <BLU437-SMTP58939005C5CAECB257AD70FEDE0@phx.gbl>
On 01/02/16 01:06, Pablo G. Gallardo wrote:
> This patch removes unnecessary typecast of c90 int constant.
>
> Signed-off-by: Pablo G. Gallardo <gallardo_pablo@hotmail.com>
> ---
> drivers/staging/comedi/comedi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 83bd309..2645081 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -516,7 +516,7 @@ struct comedi_bufinfo {
> #define UNIT_mA 1
> #define UNIT_none 2
>
> -#define COMEDI_MIN_SPEED ((unsigned int)0xffffffff)
> +#define COMEDI_MIN_SPEED (0xffffffff)
Those parentheses are unnecessary as well. I'd probably add a 'u'
suffix to the constant to avoid any possibility of it being
misinterpreted as a negative value by a pre-C90 version of the C
language, though that's probably not worth worrying about.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
parent reply other threads:[~2016-02-01 11:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <BLU437-SMTP58939005C5CAECB257AD70FEDE0@phx.gbl>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF3E9C.1040000@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=gallardo_pablo@hotmail.com \
--cc=greg@kroah.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox