From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753793AbcBALQu (ORCPT ); Mon, 1 Feb 2016 06:16:50 -0500 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:60997 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbcBALQs (ORCPT ); Mon, 1 Feb 2016 06:16:48 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 1/2] STAGING: COMEDI: Remove unnecessary typecast of c90 int constant To: "Pablo G. Gallardo" , greg@kroah.com References: Cc: hsweeten@visionengravers.com, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <56AF3E9C.1040000@mev.co.uk> Date: Mon, 1 Feb 2016 11:16:44 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/16 01:06, Pablo G. Gallardo wrote: > This patch removes unnecessary typecast of c90 int constant. > > Signed-off-by: Pablo G. Gallardo > --- > drivers/staging/comedi/comedi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h > index 83bd309..2645081 100644 > --- a/drivers/staging/comedi/comedi.h > +++ b/drivers/staging/comedi/comedi.h > @@ -516,7 +516,7 @@ struct comedi_bufinfo { > #define UNIT_mA 1 > #define UNIT_none 2 > > -#define COMEDI_MIN_SPEED ((unsigned int)0xffffffff) > +#define COMEDI_MIN_SPEED (0xffffffff) Those parentheses are unnecessary as well. I'd probably add a 'u' suffix to the constant to avoid any possibility of it being misinterpreted as a negative value by a pre-C90 version of the C language, though that's probably not worth worrying about. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-