From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Xen/PCI: correct notifier used for device removal
Date: Mon, 1 Feb 2016 12:01:21 +0000 [thread overview]
Message-ID: <56AF4911.8030208@citrix.com> (raw)
In-Reply-To: <56AF566002000078000CCE71@prv-mh.provo.novell.com>
On 01/02/16 11:58, Jan Beulich wrote:
> Commit 599bad38cf added BUS_NOTIFY_REMOVED_DEVICE in order to allow
> avoiding removal of IOMMU mappings before the driver actually got
> unbound from the device. Naturally we should be using this too.
Because otherwise...? What happens if we don't make this change?
Removing IOMMU mappings for a device when the driver is still bound to
the device looks wrong to me. Surely the device is still active and may
still be performing DMA at this point?
David
> --- 4.5-rc2/drivers/xen/pci.c
> +++ 4.5-rc2-xen-PCI-remove-notifier/drivers/xen/pci.c
> @@ -185,7 +185,7 @@ static int xen_pci_notifier(struct notif
> case BUS_NOTIFY_ADD_DEVICE:
> r = xen_add_device(dev);
> break;
> - case BUS_NOTIFY_DEL_DEVICE:
> + case BUS_NOTIFY_REMOVED_DEVICE:
> r = xen_remove_device(dev);
> break;
> default:
>
>
>
next prev parent reply other threads:[~2016-02-01 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 11:58 [PATCH] Xen/PCI: correct notifier used for device removal Jan Beulich
2016-02-01 12:01 ` David Vrabel [this message]
2016-02-01 12:16 ` Jan Beulich
2016-02-01 13:03 ` David Vrabel
2016-02-01 13:08 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF4911.8030208@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox