From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754126AbcBAMgf (ORCPT ); Mon, 1 Feb 2016 07:36:35 -0500 Received: from mail-lb0-f173.google.com ([209.85.217.173]:35789 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753671AbcBAMgc (ORCPT ); Mon, 1 Feb 2016 07:36:32 -0500 Subject: Re: [PATCH] net: smc91x: propagate irq return code To: Robert Jarzmik , Nicolas Pitre , "David S. Miller" References: <1454280377-25697-1-git-send-email-robert.jarzmik@free.fr> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <56AF514D.6010608@cogentembedded.com> Date: Mon, 1 Feb 2016 15:36:29 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454280377-25697-1-git-send-email-robert.jarzmik@free.fr> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 2/1/2016 1:46 AM, Robert Jarzmik wrote: > The smc91x driver doesn't honor the probe deferral mechanism when the > interrupt source is not yet available, such as one provided by a gpio > controller not probed. > > Fix this by propagating the platform_get_irq() error code as the probe > return value. > > Signed-off-by: Robert Jarzmik > --- > drivers/net/ethernet/smsc/smc91x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c > index 0e2fc1a844ab..43ab7aa31a79 100644 > --- a/drivers/net/ethernet/smsc/smc91x.c > +++ b/drivers/net/ethernet/smsc/smc91x.c > @@ -2343,7 +2343,7 @@ static int smc_drv_probe(struct platform_device *pdev) > > ndev->irq = platform_get_irq(pdev, 0); > if (ndev->irq <= 0) { > - ret = -ENODEV; > + ret = ndev->irq; What if 'ndev->irq' does equal 0? MBR, Sergei