From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbcBAM5P (ORCPT ); Mon, 1 Feb 2016 07:57:15 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34838 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065AbcBAM5M (ORCPT ); Mon, 1 Feb 2016 07:57:12 -0500 Subject: Re: [PATCH] mac80211: fix memory leak To: Kalle Valo , Sudip Mukherjee References: <1454060944-11320-1-git-send-email-sudipm.mukherjee@gmail.com> <20160201042548.GA4072@sudip-pc> <878u34u6d6.fsf@purkki.adurom.net> Cc: Julian Calaby , Johannes Berg , "David S. Miller" , "linux-kernel@vger.kernel.org" , linux-wireless , netdev From: Sergei Shtylyov Message-ID: <56AF5625.5030701@cogentembedded.com> Date: Mon, 1 Feb 2016 15:57:09 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <878u34u6d6.fsf@purkki.adurom.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 2/1/2016 12:28 PM, Kalle Valo wrote: >> On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote: >>> Hi Sudip, >>> >>> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee >>> wrote: >>>> On error we jumped to the error label and returned the error code but we >>>> missed releasing sinfo. >>>> >>>> Signed-off-by: Sudip Mukherjee >>> >>> Should the From: and Signed-off-by: email addresses be the same? >> >> I think 2 years back I had a long discussion with Greg about this and >> since then I al submitting patches like this. A small summayg of the >> problem from that discussion: >> >> "we have strict DMARC check for the corporate mail server. DMARC = >> domain based message authentication. >> So the mail i sent reached all the list subscriber from a different >> server than our designated server, and as a result it is marked as spam >> in many places and I have already received a few complaints regarding >> that." > > You can add a separate "From:" line to the beginning of the commit log > and git will use it then commiting the patch. I didn't find any > documention but it's easy to do and should solve this. Documentation/SubmittingPatches, clause 14. MBR, Sergei