From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932407AbcBANcK (ORCPT ); Mon, 1 Feb 2016 08:32:10 -0500 Received: from mail-lb0-f172.google.com ([209.85.217.172]:34388 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbcBANcI (ORCPT ); Mon, 1 Feb 2016 08:32:08 -0500 Subject: Re: [PATCH v2 net 3/6] net: mvneta: Remove unused code To: Gregory CLEMENT , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Thomas Petazzoni References: <1454332067-16378-1-git-send-email-gregory.clement@free-electrons.com> <1454332067-16378-4-git-send-email-gregory.clement@free-electrons.com> Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Lior Amsalem , Nadav Haklai , Marcin Wojtas , Russell King - ARM Linux , Willy Tarreau From: Sergei Shtylyov Message-ID: <56AF5E55.9030603@cogentembedded.com> Date: Mon, 1 Feb 2016 16:32:05 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454332067-16378-4-git-send-email-gregory.clement@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 2/1/2016 4:07 PM, Gregory CLEMENT wrote: > Since the commit 2dcf75e2793c ("net: mvneta: Associate RX queues with > each CPU") all the percpu irq are used and unmask at initialization, so Unmasked, you mean? > there is no point to unmask them first. Mask, maybe (looking at the patch)? > Signed-off-by: Gregory CLEMENT > --- > drivers/net/ethernet/marvell/mvneta.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 3d6e3137f305..861b7e0d7d5f 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -3009,14 +3009,6 @@ static int mvneta_open(struct net_device *dev) > goto err_cleanup_txqs; > } > > - /* Even though the documentation says that request_percpu_irq > - * doesn't enable the interrupts automatically, it actually > - * does so on the local CPU. > - * > - * Make sure it's disabled. > - */ > - mvneta_percpu_disable(pp); > - > /* Enable per-CPU interrupt on all the CPU to handle our RX > * queue interrupts > */ MBR, Sergei