From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250AbcBAPvR (ORCPT ); Mon, 1 Feb 2016 10:51:17 -0500 Received: from mga01.intel.com ([192.55.52.88]:57453 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbcBAPvQ (ORCPT ); Mon, 1 Feb 2016 10:51:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,380,1449561600"; d="scan'208";a="645216487" Subject: Re: [PATCH] crypto: aead - move aead_request_cast helper to aead.h To: Herbert Xu References: <20160127220916.12466.99501.stgit@tstruk-mobl1> <20160201094633.GA6299@gondor.apana.org.au> Cc: smueller@chronox.de, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org From: Tadeusz Struk Message-ID: <56AF7DF3.1010305@intel.com> Date: Mon, 1 Feb 2016 07:46:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160201094633.GA6299@gondor.apana.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2016 01:46 AM, Herbert Xu wrote: >> Move the helper function to common header for everybody to use. >> > >> > Signed-off-by: Tadeusz Struk > This should go into internal/aead.h if at all. Yes, I though about it, but I followed skcipher. The skcipher_request_cast() helper is in crypto/skcipher.h not in crypto/internal/skcipher.h Shouldn't this be consistent? Thanks, -- TS