* [PATCH] deadline: remove unused struct member
@ 2016-01-14 22:41 Tahsin Erdogan
2016-02-01 0:54 ` Tahsin Erdogan
0 siblings, 1 reply; 4+ messages in thread
From: Tahsin Erdogan @ 2016-01-14 22:41 UTC (permalink / raw)
To: Jens Axboe, Aaron Carroll, linux-block; +Cc: linux-kernel, Tahsin Erdogan
commit 63de428b139d3d31d86ebe25ae97b33f6540fb7e ("deadline-iosched:
allow non-sequential batching") removed last use of last_sector.
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
---
block/deadline-iosched.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c
index a753df2..d0dd788 100644
--- a/block/deadline-iosched.c
+++ b/block/deadline-iosched.c
@@ -39,7 +39,6 @@ struct deadline_data {
*/
struct request *next_rq[2];
unsigned int batching; /* number of sequential requests made */
- sector_t last_sector; /* head position */
unsigned int starved; /* times reads have starved writes */
/*
@@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq)
dd->next_rq[WRITE] = NULL;
dd->next_rq[data_dir] = deadline_latter_request(rq);
- dd->last_sector = rq_end_sector(rq);
-
/*
* take it off the sort and fifo list, move
* to dispatch queue
--
2.6.0.rc2.230.g3dd15c0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] deadline: remove unused struct member
2016-01-14 22:41 [PATCH] deadline: remove unused struct member Tahsin Erdogan
@ 2016-02-01 0:54 ` Tahsin Erdogan
2016-02-01 15:10 ` Jeff Moyer
0 siblings, 1 reply; 4+ messages in thread
From: Tahsin Erdogan @ 2016-02-01 0:54 UTC (permalink / raw)
To: Jens Axboe, Aaron Carroll, linux-block; +Cc: linux-kernel, Tahsin Erdogan
Ping?
On Thu, Jan 14, 2016 at 2:41 PM, Tahsin Erdogan <tahsin@google.com> wrote:
> commit 63de428b139d3d31d86ebe25ae97b33f6540fb7e ("deadline-iosched:
> allow non-sequential batching") removed last use of last_sector.
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
> ---
> block/deadline-iosched.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c
> index a753df2..d0dd788 100644
> --- a/block/deadline-iosched.c
> +++ b/block/deadline-iosched.c
> @@ -39,7 +39,6 @@ struct deadline_data {
> */
> struct request *next_rq[2];
> unsigned int batching; /* number of sequential requests made */
> - sector_t last_sector; /* head position */
> unsigned int starved; /* times reads have starved writes */
>
> /*
> @@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq)
> dd->next_rq[WRITE] = NULL;
> dd->next_rq[data_dir] = deadline_latter_request(rq);
>
> - dd->last_sector = rq_end_sector(rq);
> -
> /*
> * take it off the sort and fifo list, move
> * to dispatch queue
> --
> 2.6.0.rc2.230.g3dd15c0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] deadline: remove unused struct member
2016-02-01 0:54 ` Tahsin Erdogan
@ 2016-02-01 15:10 ` Jeff Moyer
2016-02-01 16:10 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Moyer @ 2016-02-01 15:10 UTC (permalink / raw)
To: Tahsin Erdogan; +Cc: Jens Axboe, Aaron Carroll, linux-block, linux-kernel
Tahsin Erdogan <tahsin@google.com> writes:
> Ping?
Yeah, commit 63de428b139d3 (deadline-iosched: allow non-sequential
batching) removed the use of last_sector, and should have removed the
structure member as well (way back in 2008).
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
> On Thu, Jan 14, 2016 at 2:41 PM, Tahsin Erdogan <tahsin@google.com> wrote:
>> commit 63de428b139d3d31d86ebe25ae97b33f6540fb7e ("deadline-iosched:
>> allow non-sequential batching") removed last use of last_sector.
>>
>> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
>> ---
>> block/deadline-iosched.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c
>> index a753df2..d0dd788 100644
>> --- a/block/deadline-iosched.c
>> +++ b/block/deadline-iosched.c
>> @@ -39,7 +39,6 @@ struct deadline_data {
>> */
>> struct request *next_rq[2];
>> unsigned int batching; /* number of sequential requests made */
>> - sector_t last_sector; /* head position */
>> unsigned int starved; /* times reads have starved writes */
>>
>> /*
>> @@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq)
>> dd->next_rq[WRITE] = NULL;
>> dd->next_rq[data_dir] = deadline_latter_request(rq);
>>
>> - dd->last_sector = rq_end_sector(rq);
>> -
>> /*
>> * take it off the sort and fifo list, move
>> * to dispatch queue
>> --
>> 2.6.0.rc2.230.g3dd15c0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] deadline: remove unused struct member
2016-02-01 15:10 ` Jeff Moyer
@ 2016-02-01 16:10 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2016-02-01 16:10 UTC (permalink / raw)
To: Jeff Moyer, Tahsin Erdogan; +Cc: Aaron Carroll, linux-block, linux-kernel
On 02/01/2016 08:10 AM, Jeff Moyer wrote:
> Tahsin Erdogan <tahsin@google.com> writes:
>
>> Ping?
>
> Yeah, commit 63de428b139d3 (deadline-iosched: allow non-sequential
> batching) removed the use of last_sector, and should have removed the
> structure member as well (way back in 2008).
Heh, just 8 years! Thanks Tahsin, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-01 16:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-14 22:41 [PATCH] deadline: remove unused struct member Tahsin Erdogan
2016-02-01 0:54 ` Tahsin Erdogan
2016-02-01 15:10 ` Jeff Moyer
2016-02-01 16:10 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox