From: Rik van Riel <riel@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
peterz@infradead.org, fweisbec@gmail.com, clark@redhat.com,
luto@amacapital.net, mingo@kernel.org
Subject: Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy
Date: Mon, 1 Feb 2016 15:08:39 -0500 [thread overview]
Message-ID: <56AFBB47.3090007@redhat.com> (raw)
In-Reply-To: <1454356843.7627.187.camel@edumazet-glaptop2.roam.corp.google.com>
On 02/01/2016 03:00 PM, Eric Dumazet wrote:
> On Mon, 2016-02-01 at 14:21 -0500, riel@redhat.com wrote:
>> From: Rik van Riel <riel@redhat.com>
>>
>
>> #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
>> +static bool vtime_jiffies_changed(struct task_struct *tsk, unsigned long now)
>> +{
>> + if (tsk->vtime_jiffies == jiffies)
>> + return false;
>> +
>> + tsk->vtime_jiffies = jiffies;
>> + return true;
>> +}
>
> I am guessing you intended to use 'now' instead of jiffies ?
Yes indeed. Good catch.
I have fixed this up in my local tree, and will wait for
more people's comments before sending out a v5 (tomorrow?).
--
All rights reversed
next prev parent reply other threads:[~2016-02-01 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 19:21 [PATCH 0/4 v4] sched,time: reduce nohz_full syscall overhead 40% riel
2016-02-01 19:21 ` [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals riel
2016-02-01 19:21 ` [PATCH 2/4] acct,time: change indentation in __acct_update_integrals riel
2016-02-01 19:21 ` [PATCH 3/4] time,acct: drop irq save & restore from __acct_update_integrals riel
2016-02-01 19:21 ` [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy riel
2016-02-01 20:00 ` Eric Dumazet
2016-02-01 20:08 ` Rik van Riel [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-02 17:19 [PATCH 0/4 v5] sched,time: reduce nohz_full syscall overhead 40% riel
2016-02-02 17:19 ` [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy riel
2016-02-09 17:11 ` Frederic Weisbecker
2016-02-09 18:13 ` Rik van Riel
2016-02-09 21:20 ` Rik van Riel
2016-02-01 2:12 [PATCH 0/4 v3] sched,time: reduce nohz_full syscall overhead 40% riel
2016-02-01 2:12 ` [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy riel
2016-02-01 9:29 ` Peter Zijlstra
2016-02-01 19:23 ` Rik van Riel
2016-01-30 3:36 [PATCH 0/2] sched,time: reduce nohz_full syscall overhead 40% riel
2016-01-30 3:36 ` [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AFBB47.3090007@redhat.com \
--to=riel@redhat.com \
--cc=clark@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).