From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753267AbcBAUIn (ORCPT ); Mon, 1 Feb 2016 15:08:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34884 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbcBAUIm (ORCPT ); Mon, 1 Feb 2016 15:08:42 -0500 Subject: Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy To: Eric Dumazet References: <1454354466-31309-1-git-send-email-riel@redhat.com> <1454354466-31309-5-git-send-email-riel@redhat.com> <1454356843.7627.187.camel@edumazet-glaptop2.roam.corp.google.com> Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, fweisbec@gmail.com, clark@redhat.com, luto@amacapital.net, mingo@kernel.org From: Rik van Riel Message-ID: <56AFBB47.3090007@redhat.com> Date: Mon, 1 Feb 2016 15:08:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1454356843.7627.187.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2016 03:00 PM, Eric Dumazet wrote: > On Mon, 2016-02-01 at 14:21 -0500, riel@redhat.com wrote: >> From: Rik van Riel >> > >> #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN >> +static bool vtime_jiffies_changed(struct task_struct *tsk, unsigned long now) >> +{ >> + if (tsk->vtime_jiffies == jiffies) >> + return false; >> + >> + tsk->vtime_jiffies = jiffies; >> + return true; >> +} > > I am guessing you intended to use 'now' instead of jiffies ? Yes indeed. Good catch. I have fixed this up in my local tree, and will wait for more people's comments before sending out a v5 (tomorrow?). -- All rights reversed