From: Laura Abbott <labbott@redhat.com>
To: John Stultz <john.stultz@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Cc: Rajmal Menariya <rajmal.menariya@spreadtrum.com>,
sprd-ind-kernel-group@googlegroups.com,
sanjeev.yadav@spreadtrum.com, Colin Cross <ccross@android.com>,
Android Kernel Team <kernel-team@android.com>,
Greg KH <gregkh@linuxfoundation.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH 6/9] staging: ion: Set minimum carveout heap allocation order to PAGE_SHIFT
Date: Mon, 1 Feb 2016 12:23:02 -0800 [thread overview]
Message-ID: <56AFBEA6.20708@redhat.com> (raw)
In-Reply-To: <1454134058-16466-7-git-send-email-john.stultz@linaro.org>
On 01/29/2016 10:07 PM, John Stultz wrote:
> From: Rajmal Menariya <rajmal.menariya@spreadtrum.com>
>
> In carveout heap, change minimum allocation order from 12 to
> PAGE_SHIFT. After this change each bit in bitmap (genalloc -
> General purpose special memory pool) represents one page size
> memory.
>
> Cc: sprd-ind-kernel-group@googlegroups.com
> Cc: sanjeev.yadav@spreadtrum.com
> Cc: Colin Cross <ccross@android.com>
> Cc: Android Kernel Team <kernel-team@android.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: Laura Abbott <labbott@redhat.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Signed-off-by: Rajmal Menariya <rajmal.menariya@spreadtrum.com>
> [jstultz: Reworked commit message]
> Signed-off-by: John Stultz <john.stultz@linaro.org>
Acked-by: Laura Abbott <labbott@redhat.com>
> ---
> drivers/staging/android/ion/ion_carveout_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c
> index 9156d82..e702ce6 100644
> --- a/drivers/staging/android/ion/ion_carveout_heap.c
> +++ b/drivers/staging/android/ion/ion_carveout_heap.c
> @@ -167,7 +167,7 @@ struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data)
> if (!carveout_heap)
> return ERR_PTR(-ENOMEM);
>
> - carveout_heap->pool = gen_pool_create(12, -1);
> + carveout_heap->pool = gen_pool_create(PAGE_SHIFT, -1);
> if (!carveout_heap->pool) {
> kfree(carveout_heap);
> return ERR_PTR(-ENOMEM);
>
next prev parent reply other threads:[~2016-02-01 20:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 6:07 [PATCH 0/9] staging: Updates from the Android tree John Stultz
2016-01-30 6:07 ` [PATCH 1/9] staging: ashmem: Avoid deadlock with mmap/shrink John Stultz
2016-01-30 6:07 ` [PATCH 2/9] staging: ashmem: Add missing include John Stultz
2016-01-30 6:07 ` [PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak John Stultz
2016-02-07 22:49 ` Greg KH
2016-02-08 18:50 ` John Stultz
2016-01-30 6:07 ` [PATCH 4/9] staging: lowmemorykiller: Make default lowmemorykiller debug message useful John Stultz
2016-01-30 6:07 ` [PATCH 5/9] staging: lowmemorykiller: Trace kill events John Stultz
2016-01-30 6:07 ` [PATCH 6/9] staging: ion: Set minimum carveout heap allocation order to PAGE_SHIFT John Stultz
2016-02-01 20:23 ` Laura Abbott [this message]
2016-01-30 6:07 ` [PATCH 7/9] staging: ion: Handle the memory mapping correctly on x86 John Stultz
2016-01-30 6:07 ` [PATCH 8/9] staging: ion: Add X86 dependency for ION_POOL_CACHE_POLICY John Stultz
2016-01-30 6:07 ` [PATCH 9/9] staging: ion: Fix page pool cache policy John Stultz
2016-02-01 21:10 ` [PATCH 0/9] staging: Updates from the Android tree Laura Abbott
2016-02-01 21:28 ` John Stultz
2016-02-07 22:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AFBEA6.20708@redhat.com \
--to=labbott@redhat.com \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajmal.menariya@spreadtrum.com \
--cc=sanjeev.yadav@spreadtrum.com \
--cc=sprd-ind-kernel-group@googlegroups.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).