From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753512AbcBAUXJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Feb 2016 15:23:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59008 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752872AbcBAUXI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Feb 2016 15:23:08 -0500
Subject: Re: [PATCH 6/9] staging: ion: Set minimum carveout heap allocation
 order to PAGE_SHIFT
To: John Stultz <john.stultz@linaro.org>, lkml <linux-kernel@vger.kernel.org>
References: <1454134058-16466-1-git-send-email-john.stultz@linaro.org>
 <1454134058-16466-7-git-send-email-john.stultz@linaro.org>
Cc: Rajmal Menariya <rajmal.menariya@spreadtrum.com>,
        sprd-ind-kernel-group@googlegroups.com, sanjeev.yadav@spreadtrum.com,
        Colin Cross <ccross@android.com>,
        Android Kernel Team <kernel-team@android.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Sumit Semwal <sumit.semwal@linaro.org>
From: Laura Abbott <labbott@redhat.com>
Message-ID: <56AFBEA6.20708@redhat.com>
Date: Mon, 1 Feb 2016 12:23:02 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <1454134058-16466-7-git-send-email-john.stultz@linaro.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/29/2016 10:07 PM, John Stultz wrote:
> From: Rajmal Menariya <rajmal.menariya@spreadtrum.com>
>
> In carveout heap, change minimum allocation order from 12 to
> PAGE_SHIFT. After this change each bit in bitmap (genalloc -
> General purpose special memory pool) represents one page size
> memory.
>
> Cc: sprd-ind-kernel-group@googlegroups.com
> Cc: sanjeev.yadav@spreadtrum.com
> Cc: Colin Cross <ccross@android.com>
> Cc: Android Kernel Team <kernel-team@android.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: Laura Abbott <labbott@redhat.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Signed-off-by: Rajmal Menariya <rajmal.menariya@spreadtrum.com>
> [jstultz: Reworked commit message]
> Signed-off-by: John Stultz <john.stultz@linaro.org>

Acked-by: Laura Abbott <labbott@redhat.com>

> ---
>   drivers/staging/android/ion/ion_carveout_heap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c
> index 9156d82..e702ce6 100644
> --- a/drivers/staging/android/ion/ion_carveout_heap.c
> +++ b/drivers/staging/android/ion/ion_carveout_heap.c
> @@ -167,7 +167,7 @@ struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data)
>   	if (!carveout_heap)
>   		return ERR_PTR(-ENOMEM);
>
> -	carveout_heap->pool = gen_pool_create(12, -1);
> +	carveout_heap->pool = gen_pool_create(PAGE_SHIFT, -1);
>   	if (!carveout_heap->pool) {
>   		kfree(carveout_heap);
>   		return ERR_PTR(-ENOMEM);
>