From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753981AbcBAWSl (ORCPT ); Mon, 1 Feb 2016 17:18:41 -0500 Received: from mail-bn1bon0082.outbound.protection.outlook.com ([157.56.111.82]:18688 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753880AbcBAWSg (ORCPT ); Mon, 1 Feb 2016 17:18:36 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O1W3AS-08-A0P-02 X-M-MSG: Subject: Re: [PATCH v2] ata: add AMD Seattle platform driver To: Arnd Bergmann References: <1452789071-4090-1-git-send-email-brijesh.singh@amd.com> <3904852.c3HykPsQQ2@wuerfel> <56AFAA46.6090403@amd.com> <5709817.yQT8N3CaLj@wuerfel> CC: , Tejun Heo , , , , Graeme Gregory From: Brijesh Singh Message-ID: <56AFD91F.4030008@amd.com> Date: Mon, 1 Feb 2016 16:15:59 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5709817.yQT8N3CaLj@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(199003)(5004730100002)(64126003)(101416001)(230700001)(586003)(92566002)(77096005)(50986999)(80316001)(36756003)(11100500001)(86362001)(2906002)(50466002)(4326007)(5008740100001)(93886004)(83506001)(3846002)(1096002)(6116002)(3470700001)(1220700001)(87936001)(65956001)(65806001)(47776003)(106466001)(2950100001)(189998001)(110136002)(105586002)(23746002)(33656002)(4001350100001)(76176999)(59896002)(54356999)(65816999)(87266999);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0714;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 218e2299-ef0e-4351-eef0-08d32b559e5c X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0714;2:IPU0OwWU0UXy1qZ7JRY8EDpc71N3Gc/EZOXK8cwAs040eDnGdMogt3ZBpvZKTj1A+FC+LztqSBDWLMNmPD6D2Or9Pt+SaAlls3sjQUjJsAk9JENR6ekoFjEyeIbxo9phDhS3NCKHXI3WJz8EluVIYyULdnL9n0S2gu3/OoropOr29veQ39W3DdA27Ljku4Bd;3:EEBftMXDD9xFzVRbRF9R0tDwOu/stNZgwUfV0MNhv4FEWomxmMSCxsISQ8heKsDpEKEgFXhqBROza6i4KRutWUhcjh8tSBoI4lg4t1w28riA5q8HZKyviVitKR+lM0u/2EjHGktikUnyqJqXWMtzbXKKoKgcejy5cfMY9Rv/nZukCppHosY1fMea3Qeh6nGwO9UH0ZGDrESIRlZaJ+4W5J2ItYXyCrWQzzgMIxKr9cc=;25:9BAb5SoctfX6WayqptPcggEPEMH7w97w2ExO3kZwJbfrMAn3t0oCQfOQa43KresylX6QJGvRzOh5dhRHDCPpLmnUUiHh//hpOZzVb78Gf3AfzIGApSVpPTDWwPCf0edpcOtwMB8tHEV303gg7cirXrT6gWWq9DfctPTxggmi6kiyIlQtUFwb768gVH2q7qIhVtWCzmWOOZQZ0uPWXFK7N7zCmglKRg1Pc3AmDw9Ut6bd51wzqUL8xqB0W65ETfqc X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0714; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0714;20:tHr8zuz69xI5nZ1TrkiQIL0/MUmuV5ElM6zhyJwExw92t33/5NxV6CKCmJQ31SeC9wNDMSMdDaYe4kbhkBDJ3bgeZGngyi9A3ANXeRheib2YTdgiC6xArgH3HzbMjP4+m06d9Zkh+4smhnEWZpe/kfOH1ySc16blc+ycNGPNLI20bRBo7DDJ2An3f4w1XV4HpZMyRHaaoRc0XOgRi7QjNWXxbbFO2F/zom7Kh7mzd0Ry4WLYYB+MNb+tFQYBwyY68XgaqhL6RB1xLItwt6zXCm7Wd/xjF24Y8x0nfNLTyxXT+SK20+vk8U0IkP6DkoL56m24dS6WGfWB+aOzCJKoG3yztchV+vg2kD0QTCNplZx7TnejhfWDtUDdga/vl2eu90g1n15TuV1Tws8Xuf1VypC+Kd0mKKKy5+avB5guDM4LgplKTwr0PgsHtw+8yWebzgMjEPKD7SlAUGFCF1Hf8CQVjNwriPRyfJBgOmN8yG+7AM9bEoL4hLzyOK+KaqAj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(13024025)(13023025)(13015025)(13017025)(13018025)(8121501046)(3002001)(10201501046);SRVR:CY1PR12MB0714;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0714; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0714;4:audBJ35x+6j4lrEzfpuYrtlMQP9UWYzDjSR8KmpmH0W2tLfpQn86X6J1pkImLGYigjpstiF5b/HibtcRYTynw25zzxpbg2pszJwhvUFSshPYv/4gAPTPMqrmOhrCTatozpM/ryBy2GvyqZ/+nr8xzvTeCnaC1m3nBviChaZeMKca3e+sMHhjPA4gKWhFo9VsE8b35kaNwSPyyUzj6cxVjrIxZ+cR+LoBt/DBqoNKJHPQrPdn3SqAw4vJuCfPIXza0hErIeLyQ6qGDIY9yh1EmWI46ye10O+TnOY115u1q/MYWygip2Ar58OWXohzpzQc5ot5L3wb7iaxKK6tgHdPL4NqCnWlX6Dl6YdleMrHmXwUJT5FM34wqD9L1qFY5pq2q+hK0cmcnSXJtsbxz5BffCE7Gn8jJMI8zrp/LLz2WWFdtR4h80PrAjsH4MzABTDFrZY3ifG5GysmHhUgg2hPNg== X-Forefront-PRVS: 0839D067E7 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR12MB0714;23:shQxKSy81PVYaJ7dQJgSGjvIzNOIVOe/kj/IA?= =?Windows-1252?Q?GUS9ShSY5ajAMcAFzoMzk8Gq3KeCsWP1e2TugGDaDHoakGXnuAVNgK7N?= =?Windows-1252?Q?5YNcRS8QiQi4ppOVR1IJFSe6PSTmVQ9/o2lbruVuOdq1HTQo9dUhdDs4?= =?Windows-1252?Q?R2Z2i4hLcwMiUW9BSMSv4u8TlNe3BLWelDGFR9RPTANHLWlTmW7ouIg8?= =?Windows-1252?Q?fCO65P+lMz7pVC9eskBfnxhN3PPJ4M5CvSTqGxRQFVwyCg9AK/1lTD7V?= =?Windows-1252?Q?VK2Y47kabhaWSOU9aKuFllOk+T0iYndCY1DeTCxNLe6KKvTHaJmdof3S?= =?Windows-1252?Q?JCLf+JH+yYyZHb/N1o3n1/t83+QaF0Z0XyJrkPMd00Wo+ffmvAmFksla?= =?Windows-1252?Q?ftdURcmMwnGFBISTsUyYTegBxgdKF+paKsXAVNPNj0Ye8RgSAq4H3IHN?= =?Windows-1252?Q?wHndEBv/n5csMQCdwd9KccO31eI2qcglp3KUxDoXZVRBiMrAyyP/1OP7?= =?Windows-1252?Q?QYXR9HTE2s68dyvhWC2qUG3ixll7oJdbDI9pWvQS3ErTqcEfdZRWd41P?= =?Windows-1252?Q?0fmhOu/8+wG6y0HsIZlP8iv9nkCW6gkIYMDUCfR3sXxt59Ce3j8QmloN?= =?Windows-1252?Q?gTbpOyumGy9NOzbQIhpaBKDWiCPoERSY4rmUbCAo4wmd9n4uMz3Vt2Em?= =?Windows-1252?Q?lVpv9GQnq1C1PE8TR9pH1WuKr7JEfYAx0LYuHRLJsAy93EG03myiDPcb?= =?Windows-1252?Q?r/qHWYIrjimOG6S+wzWKSLVUgISSopLT0/GaqWkIr0WCMK+E1WRSM4tf?= =?Windows-1252?Q?zLB+GIvWXu+hSw3dPOv7XSnVuQrGjTCOVHA9LVOKCKW/abWyWpWPfUNl?= =?Windows-1252?Q?rWzGLvOnQVtGJg0XlayATqPuIj4zkUXdjy/8esJJlBd/eQ44bRm7htZD?= =?Windows-1252?Q?mfYEgM/sjh9JSe5GJR/hNUiR9ZgKHneuPBiA56WtCORRjm0o98w5VR09?= =?Windows-1252?Q?iRgkflFS4rbKk+REdKoBeqjlwe16g+fRp7knqG8JRvu/xeEVadWY8d77?= =?Windows-1252?Q?b8aEotnBe53I25ehTgoZvsHXgjNRgiGJ6prV/xx/Z0GGZYhWK2Ld3oHD?= =?Windows-1252?Q?E7Eg0Qj2K+7u+5nhXW36NRlFeTaJB8wmpEEQ54gEi8R9QAxdNdvIeNd1?= =?Windows-1252?Q?WQAw+cH4EWFyfwdkXAf5S35tfkDC+BTP+ZL5Ee4zuKvwSJVN1itdqahb?= =?Windows-1252?Q?3kXoc+xgyH7UbuDIw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0714;5:CTPeKxw4YAyj0bQpJf2mYZnt7Zfn35Q0vj1xZFgDNeLUV3JfzHNMHejL/D7ZVtqlIDDreVg5LbA6zqZahTcaoP1qi+3vl+hHMSq8UJn8eKFQEdtRC/gKoZN+Y2vdd3iSfW2YJs5eQLxDZIh5a8ahZA==;24:+78iPStAONOJ2PpNJj9R6XYecBXL5RemAO3QsET02shFGY6s68nHIx/x14whGtgzhvizK9o3QKc4a8HlWHbms51oTzhcTI9MStjw0h3yjhc=;20:BYvXEG02SJA+QxQCSMCrLcABySNg/diJeFlWMNXq8VemMSiZQtja2E4tiTZnX1utN5EVSK4Qm2tQ7ZDNrI9JomEIKqgf3rjvu1Lctr79trNLRssavmUPf0nk2jrhJ8nPaYDhmeVoHFcQJk5nCuaFAz200JQeYYhfHpirIi2VYPB+NGIksRKpbuD/R1vyYFxHm7QGVHSb8FBx5k40lqvJHlx2hhtiiwP5SsOltwhzf1otcXIipkrAuLM20tGcmgOm SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2016 22:18:31.3633 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0714 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > This is where we really need the ACPI maintainers to explain the > general policy for dealing with firmware updates. > > I would assume that adding the feature in a later firmware version > is a compatible change, and the feature is non-essential (the > device will work fine with the generic SATA driver, except > the LEDs don't blink), so it's not a big deal, it's just what > you get for having the firmware shipped before the driver is > reviewed (don't do that). > Agreed, the driver should have been reviewed earlier. And now changes in firmware will also require them changing other OSes drivers. Just speaking my mind, maybe server folks will be fine without activity LED but I think "locate" and "fault" LEDs is needed. -Brijesh > Arnd >