From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753939AbcBBICK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Feb 2016 03:02:10 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:28204 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753110AbcBBICJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Feb 2016 03:02:09 -0500
Message-ID: <56B06252.5080504@oracle.com>
Date: Tue, 02 Feb 2016 16:01:22 +0800
From: Ryan Ding <ryan.ding@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0
MIME-Version: 1.0
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Mark Fasheh <mfasheh@suse.com>, Joel Becker <jlbec@evilplan.org>
CC: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH] ocfs2: fix build warning
References: <1454395613-3428-1-git-send-email-sudipm.mukherjee@gmail.com>
In-Reply-To: <1454395613-3428-1-git-send-email-sudipm.mukherjee@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 02/02/2016 02:46 PM, Sudip Mukherjee wrote:
> We were getting build warning about:
> /fs/ocfs2/file.c: In function ‘ocfs2_file_write_iter’:
> fs/ocfs2/file.c:2198:1: warning: label ‘relock’ defined but not used
>
> The previous commit has cleaned up the code for direct io and removed
> the jump instruction to relock, but missed removing the label which is
> unused now.
>
> Fixes: 1a46f12e5071 ("ocfs2: code clean up for direct io")
> Cc: Ryan Ding <ryan.ding@oracle.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

Reviewed-by: Ryan Ding<ryan.ding@oracle.com>

> ---
>   fs/ocfs2/file.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 41c506e..c18ab45 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2195,7 +2195,6 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb,
>   
>   	inode_lock(inode);
>   
> -relock:
>   	/*
>   	 * Concurrent O_DIRECT writes are allowed with
>   	 * mount_option "coherency=buffered".