From: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: mingo@kernel.org, peterz@infradead.org,
linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com,
naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [PATCH v2 1/3] perf kvm: Introduce evsel as argument to perf_event__preprocess_sample
Date: Tue, 2 Feb 2016 14:37:09 +0530 [thread overview]
Message-ID: <56B071BD.30204@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160201205333.GD20817@kernel.org>
HI acme,
Thanks for reviewing the patch.
On Tuesday 02 February 2016 02:23 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 22, 2016 at 11:28:10AM +0530, Ravi Bangoria escreveu:
>> This patch changes prototype of perf_event__preprocess_sample() with
>> additional argument evsel added at last.
>>
>> This change is required because perf_event__preprocess_sample()
>> function will use evsel to determine cpumode of samples for powerpc
>> architecture.
>>
>> Signed-off-by: Ravi Bangoria<ravi.bangoria@linux.vnet.ibm.com>
> Fixing these problems:
>
>
>
> CC /tmp/build/perf/ui/gtk/util.o
> util/event.c: In function ‘perf_event__preprocess_sample’:
> util/event.c:1302:26: error: unused parameter ‘evsel’ [-Werror=unused-parameter]
> struct perf_evsel *evsel)
> ^
> cc1: all warnings being treated as errors
> mv: cannot stat ‘/tmp/build/perf/util/.event.o.tmp’: No such file or directory
> /home/acme/git/linux/tools/build/Makefile.build:77: recipe for target '/tmp/build/perf/util/event.o' failed
> make[3]: *** [/tmp/build/perf/util/event.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> CC /tmp/build/perf/ui/gtk/helpline.o
> CC /tmp/build/perf/arch/common.o
> /home/acme/git/linux/tools/build/Makefile.build:116: recipe for target 'util' failed
> make[2]: *** [util] Error 2
> make[2]: *** Waiting for unfinished jobs....
Thanks for pointing this out. Actually I was not aware about this.
Will take care next time onwards.
Regards,
Ravi
next prev parent reply other threads:[~2016-02-02 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 5:58 [PATCH v2 0/3] perf kvm: Guest Symbol Resolution for powerpc Ravi Bangoria
2016-01-22 5:58 ` [PATCH v2 1/3] perf kvm: Introduce evsel as argument to perf_event__preprocess_sample Ravi Bangoria
2016-02-01 20:53 ` Arnaldo Carvalho de Melo
2016-02-02 9:07 ` Ravi Bangoria [this message]
2016-01-22 5:58 ` [PATCH v2 2/3] perf kvm: enable record|report feature on powerpc Ravi Bangoria
2016-02-01 21:06 ` Arnaldo Carvalho de Melo
2016-02-02 9:06 ` Ravi Bangoria
2016-02-09 10:47 ` Ravi Bangoria
2016-01-22 5:58 ` [PATCH v2 3/3] perf kvm: Fix output fields instead of 'trace' for perf kvm report " Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B071BD.30204@linux.vnet.ibm.com \
--to=ravi.bangoria@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=hemant@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).