From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754207AbcBBJHX (ORCPT ); Tue, 2 Feb 2016 04:07:23 -0500 Received: from e34.co.us.ibm.com ([32.97.110.152]:57558 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753962AbcBBJHS (ORCPT ); Tue, 2 Feb 2016 04:07:18 -0500 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: ravi.bangoria@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org From: Ravi Bangoria Subject: Re: [PATCH v2 1/3] perf kvm: Introduce evsel as argument to perf_event__preprocess_sample To: Arnaldo Carvalho de Melo References: <1453442292-7790-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1453442292-7790-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20160201205333.GD20817@kernel.org> Cc: mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com Message-ID: <56B071BD.30204@linux.vnet.ibm.com> Date: Tue, 2 Feb 2016 14:37:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160201205333.GD20817@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16020209-0017-0000-0000-000011BB0081 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI acme, Thanks for reviewing the patch. On Tuesday 02 February 2016 02:23 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 22, 2016 at 11:28:10AM +0530, Ravi Bangoria escreveu: >> This patch changes prototype of perf_event__preprocess_sample() with >> additional argument evsel added at last. >> >> This change is required because perf_event__preprocess_sample() >> function will use evsel to determine cpumode of samples for powerpc >> architecture. >> >> Signed-off-by: Ravi Bangoria > Fixing these problems: > > > > CC /tmp/build/perf/ui/gtk/util.o > util/event.c: In function ‘perf_event__preprocess_sample’: > util/event.c:1302:26: error: unused parameter ‘evsel’ [-Werror=unused-parameter] > struct perf_evsel *evsel) > ^ > cc1: all warnings being treated as errors > mv: cannot stat ‘/tmp/build/perf/util/.event.o.tmp’: No such file or directory > /home/acme/git/linux/tools/build/Makefile.build:77: recipe for target '/tmp/build/perf/util/event.o' failed > make[3]: *** [/tmp/build/perf/util/event.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... > CC /tmp/build/perf/ui/gtk/helpline.o > CC /tmp/build/perf/arch/common.o > /home/acme/git/linux/tools/build/Makefile.build:116: recipe for target 'util' failed > make[2]: *** [util] Error 2 > make[2]: *** Waiting for unfinished jobs.... Thanks for pointing this out. Actually I was not aware about this. Will take care next time onwards. Regards, Ravi