From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Joshua Henderson <joshua.henderson@microchip.com>,
linux-kernel@vger.kernel.org
Cc: Cristian Birsan <cristian.birsan@microchip.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine
Date: Tue, 2 Feb 2016 16:32:52 +0300 [thread overview]
Message-ID: <56B0B004.5020905@cogentembedded.com> (raw)
In-Reply-To: <1454373466-28733-2-git-send-email-joshua.henderson@microchip.com>
On 2/2/2016 3:37 AM, Joshua Henderson wrote:
> From: Cristian Birsan <cristian.birsan@microchip.com>
>
> Commit 6b6e97107f12f3a9f7 (USB: musb: fix isochronous TXDMA (take 2)) introduces
Again, wrong commit style. And I really doubt that blaming my commit was
correct. :-)
> a problem setting the desired channel mode for the Mentor DMA engine.
>
> There is a case where the pointer of the channel DMA mode is incorrectly
> assigned to a pointer value, when it should be assigned the actual mode value.
> This results in the value of channel->desired_mode not being correct.
>
> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> ---
> drivers/usb/musb/musb_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index 3fdc99b..748379e 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -662,7 +662,7 @@ static int musb_tx_dma_set_mode_mentor(struct dma_controller *dma,
Hm, there was no such function at the time of my commit...
> csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE);
> csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */
> }
> - channel->desired_mode = mode;
> + channel->desired_mode = *mode;
'mode' was 'u8' at the time of my commit, see:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6b6e97107f12f3a9f7b5b43a6c3b94409240bcff
I think that the recent commit below should be blamed instead:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=754fe4a92c072a6e36d89fa328ed789c9ebc1af5
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-02-02 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 0:37 [PATCH 1/2] usb: musb: Fix DMA for host mode Joshua Henderson
2016-02-02 0:37 ` [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson
2016-02-02 13:32 ` Sergei Shtylyov [this message]
2016-02-02 16:36 ` Joshua Henderson
2016-02-02 16:51 ` Sergei Shtylyov
2016-02-02 13:24 ` [PATCH 1/2] usb: musb: Fix DMA for host mode Sergei Shtylyov
2016-02-04 16:44 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B0B004.5020905@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=cristian.birsan@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=joshua.henderson@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).