From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755990AbcBBQVa (ORCPT ); Tue, 2 Feb 2016 11:21:30 -0500 Received: from smtp.citrix.com ([66.165.176.89]:8223 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755780AbcBBQV2 (ORCPT ); Tue, 2 Feb 2016 11:21:28 -0500 X-IronPort-AV: E=Sophos;i="5.22,385,1449532800"; d="scan'208";a="329184205" Subject: Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs To: Boris Ostrovsky , , References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com> <1454341137-14110-8-git-send-email-boris.ostrovsky@oracle.com> CC: , , , From: David Vrabel Message-ID: <56B0D786.7000002@citrix.com> Date: Tue, 2 Feb 2016 16:21:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454341137-14110-8-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This needs some more description in the commit message. > --- a/arch/x86/xen/smp.c > +++ b/arch/x86/xen/smp.c [...] > + hctxt->cpu_regs.x86_32.cs_base = 0; > + hctxt->cpu_regs.x86_32.cs_limit = ~0u; > + hctxt->cpu_regs.x86_32.cs_ar = 0xc9b; > + hctxt->cpu_regs.x86_32.ds_base = 0; > + hctxt->cpu_regs.x86_32.ds_limit = ~0u; > + hctxt->cpu_regs.x86_32.ds_ar = 0xc93; > + hctxt->cpu_regs.x86_32.es_base = 0; > + hctxt->cpu_regs.x86_32.es_limit = ~0u; > + hctxt->cpu_regs.x86_32.es_ar = 0xc93; > + hctxt->cpu_regs.x86_32.ss_base = 0; > + hctxt->cpu_regs.x86_32.ss_limit = ~0u; > + hctxt->cpu_regs.x86_32.ss_ar = 0xc93; > + hctxt->cpu_regs.x86_32.tr_base = 0; > + hctxt->cpu_regs.x86_32.tr_limit = 0xff; > + hctxt->cpu_regs.x86_32.tr_ar = 0x8b; Lots of hard-coded values here. Should this be #defined somewhere? David