From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755765AbcBBQ1a (ORCPT ); Tue, 2 Feb 2016 11:27:30 -0500 Received: from smtp.citrix.com ([66.165.176.89]:65371 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbcBBQ13 (ORCPT ); Tue, 2 Feb 2016 11:27:29 -0500 X-IronPort-AV: E=Sophos;i="5.22,385,1449532800"; d="scan'208";a="329185764" Subject: Re: [Xen-devel] [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests To: Boris Ostrovsky , , References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com> <1454341137-14110-10-git-send-email-boris.ostrovsky@oracle.com> CC: , , , From: David Vrabel Message-ID: <56B0D8DD.5010206@citrix.com> Date: Tue, 2 Feb 2016 16:27:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454341137-14110-10-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/16 15:38, Boris Ostrovsky wrote: > xen_timer_init() will be called from apic_bsp_setup(). I must be missing something because xen_init_time_ops() is only called from the PV-only xen_start_kernel()? David > --- a/arch/x86/xen/time.c > +++ b/arch/x86/xen/time.c > @@ -492,7 +492,10 @@ void __init xen_init_time_ops(void) > { > pv_time_ops = xen_time_ops; > > - x86_init.timers.timer_init = xen_time_init; > + if (!xen_hvmlite) > + x86_init.timers.timer_init = xen_time_init; > + else > + x86_init.timers.timer_init = x86_init_noop; > x86_init.timers.setup_percpu_clockev = x86_init_noop; > x86_cpuinit.setup_percpu_clockev = x86_init_noop; > >