From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756189AbcBBQj4 (ORCPT ); Tue, 2 Feb 2016 11:39:56 -0500 Received: from smtp.citrix.com ([66.165.176.89]:13994 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbcBBQjx (ORCPT ); Tue, 2 Feb 2016 11:39:53 -0500 X-IronPort-AV: E=Sophos;i="5.22,385,1449532800"; d="scan'208";a="329189791" Subject: Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest To: Boris Ostrovsky , , References: <1454341137-14110-1-git-send-email-boris.ostrovsky@oracle.com> <1454341137-14110-3-git-send-email-boris.ostrovsky@oracle.com> CC: , , , From: David Vrabel Message-ID: <56B0DBD6.3060205@citrix.com> Date: Tue, 2 Feb 2016 16:39:50 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454341137-14110-3-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/16 15:38, Boris Ostrovsky wrote: > --- a/include/xen/xen.h > +++ b/include/xen/xen.h > @@ -29,6 +29,12 @@ extern enum xen_domain_type xen_domain_type; > #define xen_initial_domain() (0) > #endif /* CONFIG_XEN_DOM0 */ > > +#ifdef CONFIG_XEN_PVHVM > +extern int xen_hvmlite; > +#else > +#define xen_hvmlite (0) > +#endif I think we want a feature set and not a single boolean here. There's going to HVMlite variants (e.g., those with an emulated APIC to support PCI passthrough and those without). So we test e.g., xen_hvm_feature(XEN_HVM_FEATURE_APIC), which would be clear for a HVMlite guest without an (emulated) APIC. David